Remove custom locking in KeyedServiceCollectionAdapter#7757
Open
danielmarbach wants to merge 1 commit into
Open
Remove custom locking in KeyedServiceCollectionAdapter#7757danielmarbach wants to merge 1 commit into
danielmarbach wants to merge 1 commit into
Conversation
…in collection is already thread-safe and we don't need to double lock since this locking would also affect production scenarios which are inheritently not thread safe anyway and the code was only introduced to make concurrent endpoint initialization thread safe.
andreasohlund
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #7756
Remove custom locking in KeyedServiceCollectionAdapter because the main collection is already thread-safe, and we don't need to double lock since this locking would also affect production scenarios, which are inherently not thread-safe anyway, and the code was only introduced to make concurrent endpoint initialization in acceptance tests thread-safe.