Repository navigation
Don't open sign editor when placing signs with existing text - #14314
Open
andrewhong04 wants to merge 3 commits into
Open
andrewhong04 wants to merge 3 commits into
andrewhong04 wants to merge 3 commits into
Conversation
Warriorrrr
requested changes
Sep 28, 2026
Warriorrrr
left a comment
Warriorrrr
left a comment
Member
There was a problem hiding this comment.
This change prevents the editor from being opened when placing an empty sign
andrewhong04
force-pushed
the
fix/sign-editor-on-place
branch
from
October 11, 2026 10:41
30ed616 to
cc0653e
Compare
Author
|
Sorry for the late change, I've just squashed and pushed my changes. I've tested placing an empty sign, editing a sign after it's been placed, editing a sign when placing, and placing a ctrl-copied sign. Please let me know if you need anything else, thanks. |
Member
|
Seems better based on my testing now, have you also tested this with a sign containing more complex components like the original issue reported having issues with, just to be sure? |
Warriorrrr
approved these changes
Oct 25, 2026
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14311
This mimics the former behavior in 26.2 when placing signs with custom data, video shows a demo.
8mb.video-aee-BjojmIZS.mp4