WIP Prevent zero shares being deposited#229
Draft
naddison36 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertToShares(assets)returns0.Details
convertToShares()rounds down, so iftotalAssets()is slightly greater thantotalSupply(), a very small deposit can transfer liquidity assets while minting zero LP shares._deposit()now checks the computed share amount before transferring assets and reverts withARM: zero shareswhen the deposit would mint nothing.Testing
forge test --match-path test/unit/OriginARM/Deposit.solContract Sizes
forge build --sizesreports:EtherFiARMis currently 60 bytes over the EIP-170 runtime size limit, soforge build --sizesexits with a size-limit error.