Value base assets in the base withdrawal queue at the cross price#225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Value pending base-asset redemptions at the live
crossPriceintotalAssets()so moving base assets into an adapter withdrawal queue does not create an immediate NAV bump.Changes
AbstractARM._availableAssets()to discountpendingRedeemAssetsbycrossPrice.pendingRedeemAssetsstorage semantics unchanged as the undiscounted liquidity-denominated expected redemption amount.Motivation
On-hand base assets were already valued at
crossPrice, but pending adapter redemptions were previously valued at full expected liquidity. That meant requesting a base-asset redemption could immediately increase ARM NAV, creating an opportunity for new LPs to capture value from sudden yield jumps before redemption completes.This change keeps queued base assets valued consistently with on-hand base assets.
Test Plan
forge test --match-path test/unit/OriginARM/TotalAssets.solforge test --match-path test/fork/LidoARM/TotalAssets.t.solforge test --match-path test/fork/OriginARM/VaultInteractions.solforge test --match-path test/fork/EtherFiARM/RequestWithdraw.t.solforge test --match-path test/fork/EthenaARM/RequestWithdraw.t.solforge fmt --check src/contracts/AbstractARM.sol test/unit/OriginARM/TotalAssets.solgit diff --check -- src/contracts/AbstractARM.sol test/unit/OriginARM/TotalAssets.sol