[FIX] Fix false-positive constant buffer unregister errors and noisy log. - #2131
Open
Neloreck wants to merge 1 commit into
Open
[FIX] Fix false-positive constant buffer unregister errors and noisy log.#2131Neloreck wants to merge 1 commit into
Neloreck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
dx11ConstantBufferis registered in exactly one per-context registry, but its destructor attempted to unregister from allR__NUM_CONTEXTSregistries. Every destroyed buffer produced guaranteed misses in the remaining registries, flooding the log with thousands of! ERROR: Failed to find compiled constant bufferlines on level unload and renderer teardown — all false positives. With the owning context tracked, the error can only fire on genuine registry corruption.Changes
m_context_idtodx11ConstantBuffer, stamped byCResourceManager::_CreateConstantBufferat registration time._DeleteConstantBuffer(m_context_id, this)call, guarded byRF_REGISTEREDand aVERIFYon the context id.GetBufferName()accessor.Links
Introduced as side effect with #1331