Repository navigation
fix: strict-mode hardening, zero-sink counting, udev root re-exec - #25
Conversation
|| true guards keep no-match greps from aborting set -euo pipefail callers (with regression tests that source the lib in strict mode); count_csv fixes the zero-sink case where 'echo "" | wc -l' counted 1 and defeated the retry loop; combine-sinks re-execs as the OVOS user when udev triggers it as root so pactl reaches the user session; install.sh installs pipewire-pulse + pulseaudio-utils so the pactl paths work on generic systems. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Final pass of the perfection sweep (follows #20–#24):
|| trueon all no-match grep pipelines inlib/audio-utils.sh— the tools run underset -euo pipefail, where an empty lookup aborted the caller. New bats tests source the lib under strict mode with an ERR trap to lock this in.echo "" | wc -lreturns 1, so an empty sink list counted as one sink and the combine-sinks retry loop never retried.count_csvhandles the empty string.pipewire-pulse+pulseaudio-utilsso the pactl-based implementations work on generic (non-raspOVOS) systems; README matrix wording corrected.31 bats tests green; shellcheck green.
🤖 Generated with Claude Code