Skip to content

fix(en-US): restore full-sentence phrasings lost in the .intent migration #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikejgray merged 1 commit into from
Oct 10, 2026
Merged

fix(en-US): restore full-sentence phrasings lost in the .intent migration #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions locale/en-US/vocab/adult_mode_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
hurt me plenty
(please |)hurt me plenty (please|)
(turn off|disable|deactivate) grandma mode (please|)
(turn|switch) grandma mode off (please|)
(turn on|enable|activate) (adult|spicy) mode (please|)
5 changes: 5 additions & 0 deletions locale/en-US/vocab/arnold_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
arnold say
terminator say
schwarzenegger say
what would (arnold|the terminator|schwarzenegger|arnold schwarzenegger) say
(arnold|terminator|the terminator|schwarzenegger) say something
say something like (arnold|the terminator|schwarzenegger|arnold schwarzenegger)
(talk|speak|sound) like (arnold|the terminator|schwarzenegger|arnold schwarzenegger)
do your (arnold|terminator|schwarzenegger) (impression|voice)
5 changes: 5 additions & 0 deletions locale/en-US/vocab/bender_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
bender say
what would bender say
bender say something
say something like bender
(talk|speak|sound) like bender
do your bender (impression|voice)
4 changes: 4 additions & 0 deletions locale/en-US/vocab/bill_and_ted_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ stallion
stallions
wild stallions
wild stallion
wyld (stallions|stallyns|stallion)
(you know |)the best band in the world (is |)(wild|wyld) (stallions|stallyns)
(you know |)the best band in the world
(what is|what's|whats|who is|who's|whos) the best band in the world
4 changes: 4 additions & 0 deletions locale/en-US/vocab/conan_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
what is best in life
(what's|whats) best in life
conan what is best in life
what is best in life conan
tell me what is best in life
5 changes: 5 additions & 0 deletions locale/en-US/vocab/duke_nukem_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@ duke newcom say
duke newum say
duke newham say
duke newcomb say
what would duke (nukem|newcom|newum|newham|newcomb) say
duke (nukem|newcom|newum|newham|newcomb) say something
say something like duke (nukem|newcom|newum|newham|newcomb)
(talk|speak|sound) like duke (nukem|newcom|newum|newham|newcomb)
do your duke (nukem|newcom|newum|newham|newcomb) (impression|voice)
5 changes: 5 additions & 0 deletions locale/en-US/vocab/glados_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ glados say
gladis say
gladdos say
gladys say
what would (glados|gladis|gladdos|gladys) say
(glados|gladis|gladdos|gladys) say something
say something like (glados|gladis|gladdos|gladys)
(talk|speak|sound) like (glados|gladis|gladdos|gladys)
do your (glados|gladis|gladdos|gladys) (impression|voice)
4 changes: 4 additions & 0 deletions locale/en-US/vocab/grandma_mode_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
too young to die
(i'm|i am|im) too young to die
(please |)(turn on|enable|activate) grandma mode (please|)
(turn|switch) grandma mode (on|back on) (please|)
(turn off|disable|deactivate) (adult|spicy) mode (please|)
5 changes: 5 additions & 0 deletions locale/en-US/vocab/hal_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@ howl 9000 say
howl nine thousand say
how 9000 say
how nine thousand say
what would hal (9000 |)say
hal (9000 |)say something
say something like hal (9000|)
(talk|speak|sound) like hal (9000|)
do your hal (9000 |)(impression|voice)
4 changes: 4 additions & 0 deletions locale/en-US/vocab/languages_you_speak_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
languages do you speak
languages can you speak
(how many|what|which) languages (do|can) you speak
(how many|what|which) languages do you (know|understand)
(do|can) you speak (other|any other|multiple|more than one|many) languages
(what|which) languages are you fluent in
5 changes: 5 additions & 0 deletions locale/en-US/vocab/malibu_stacey_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@ malla boo stay see
what would malibu stacy do
what wood malley boo stay see do
what wood malla boo stay see do
malibu stacey
what would malibu (stacy|stacey) (say|do)
malibu (stacy|stacey) say something
say something like malibu (stacy|stacey)
(talk|speak|sound) like malibu (stacy|stacey)
3 changes: 3 additions & 0 deletions locale/en-US/vocab/pod_bay_doors_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
open the pod bay doors
open pod bay doors
(hal |)(please |)open the pod bay doors (hal|please|)
(hal |)(please |)open the pod bay door (hal|please|)
(hal |)(can|could|would|will) you (please |)open the pod bay doors (hal|please|)
6 changes: 6 additions & 0 deletions locale/en-US/vocab/portal_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ portal song
like glados
like portal
forrtal song
do you like (portal|glados)
sing (me |)(the |)(portal|glados) song (please|)
(play|do) (me |)(the |)(portal|glados) song (please|)
sing (like|as) glados (please|)
(sing|play) (me |)still alive (please|)
(sing|play) (me |)want you gone (please|)
4 changes: 4 additions & 0 deletions locale/en-US/vocab/rock_paper_scissors_lizard_spock_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
rock paper scissors lizard spock
how (do you|do i|to) play rock paper scissors lizard spock
(what are|explain|tell me) the rules (of|for|to) rock paper scissors lizard spock
how does rock paper scissors lizard spock work
(let's|lets) play rock paper scissors lizard spock
7 changes: 7 additions & 0 deletions locale/en-US/vocab/sing_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
sing
sing me a song
sing (me |)(a |)(song|tune|little song) (please|)
sing (me |)another song (please|)
sing (something|for me|me something) (please|)
(please |)(can|could|would|will) you sing (me |)(a |)(song|something|) (please|)
(please |)(can|could|would|will) you sing (for me|please|)
do you (know how to |)sing
i (want|would like) you to sing (me |)(a |)(song|something|)
5 changes: 5 additions & 0 deletions locale/en-US/vocab/stardate_intent.intent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ current stardate
current star date
current startdate
current start date
(what is|what's|whats) the (current |)(stardate|star date|startdate|start date)
(what is|what's|whats) (today's|todays) (stardate|star date)
(tell me|give me|computer) the (current |)(stardate|star date) (please|)
(what|which) (stardate|star date) is it (today|now|)
(stardate|star date) (please|)
16 changes: 16 additions & 0 deletions test/end2end/golden_utterances.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,19 @@
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "tell me the first law of robotics", "intent_method": "handle_robotic_laws_intent", "intent_label": "law_of_robotics.intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "recite the first law of robotic", "intent_method": "handle_robotic_laws_intent", "intent_label": "law_of_robotics.intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "speak first law of robotics", "intent_method": "handle_robotic_laws_intent", "intent_label": "law_of_robotics.intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would arnold say", "intent_method": "handle_arnold_intent", "intent_label": "arnold_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what is the current stardate", "intent_method": "handle_stardate_intent", "intent_label": "stardate_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "turn off grandma mode", "intent_method": "handle_adult_mode", "intent_label": "adult_mode_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "i'm too young to die", "intent_method": "handle_grandma_mode", "intent_label": "grandma_mode_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would bender say", "intent_method": "handle_bender_intent", "intent_label": "bender_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "conan what is best in life", "intent_method": "handle_conan_intent", "intent_label": "conan_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would duke nukem say", "intent_method": "handle_dukenukem_intent", "intent_label": "duke_nukem_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would glados say", "intent_method": "handle_glados_intent", "intent_label": "glados_intent", "intent_type": "padatious", "expected_messages": ["ovos.common_play.play"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would hal 9000 say", "intent_method": "handle_hal_intent", "intent_label": "hal_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "how many languages do you speak", "intent_method": "handle_number_of_languages_intent", "intent_label": "languages_you_speak_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "hal open the pod bay doors", "intent_method": "handle_pod_intent", "intent_label": "pod_bay_doors_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "do you like portal", "intent_method": "handle_portal_intent", "intent_label": "portal_intent", "intent_type": "padatious", "expected_messages": ["ovos.common_play.play"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "how do you play rock paper scissors lizard spock", "intent_method": "handle_rock_paper_scissors_lizard_spock_intent", "intent_label": "rock_paper_scissors_lizard_spock_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "you know the best band in the world wild stallions", "intent_method": "handle_bill_and_ted_intent", "intent_label": "bill_and_ted_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "what would malibu stacey say", "intent_method": "handle_malibu_stacey_intent", "intent_label": "malibu_stacey_intent", "intent_type": "padatious", "expected_messages": ["mycroft.audio.play_sound"], "needs_manual": false}
{"skill_id": "skill-easter-eggs.openvoiceos", "utterance": "can you sing", "intent_method": "handle_sing_intent", "intent_label": "sing_intent", "intent_type": "padatious", "expected_messages": ["speak"], "needs_manual": false}
37 changes: 37 additions & 0 deletions test/test_intents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,48 @@ en-US:
- arnold say
- terminator say
- schwarzenegger say
- what would arnold say
- talk like the terminator
- say something like schwarzenegger
stardate_intent:
- current stardate
- current star date
- current startdate
- current start date
- what is the current stardate
- what's the stardate
- tell me the stardate please
adult_mode_intent:
- hurt me plenty
- turn off grandma mode
- enable adult mode
grandma_mode_intent:
- too young to die
- i'm too young to die
- turn grandma mode back on
bender_intent:
- bender say
- what would bender say
- bender say something
conan_intent:
- what is best in life
- what's best in life
- conan what is best in life
duke_nukem_intent:
- duke nukem say
- duke newcom say
- duke newum say
- duke newham say
- duke newcomb say
- what would duke nukem say
- talk like duke nukem
glados_intent:
- glados say
- gladis say
- gladdos say
- gladys say
- what would glados say
- do your glados impression
hal_intent:
- HAL say
- HAL 9000 say
Expand All @@ -38,12 +56,19 @@ en-US:
- howl nine thousand say
- how 9000 say
- how nine thousand say
- what would hal 9000 say
- say something like hal
languages_you_speak_intent:
- languages do you speak
- languages can you speak
- how many languages do you speak
- what languages can you speak
pod_bay_doors_intent:
- open the pod bay doors
- open pod bay doors
- hal open the pod bay doors
- open the pod bay doors hal
- could you please open the pod bay doors
portal_intent:
- sing portal
- sing glados
Expand All @@ -56,23 +81,35 @@ en-US:
- like glados
- like portal
- forrtal song
- do you like portal
- sing the portal song
- play still alive
rock_paper_scissors_lizard_spock_intent:
- rock paper scissors lizard spock
- how do you play rock paper scissors lizard spock
- explain the rules of rock paper scissors lizard spock
bill_and_ted_intent:
- stallion
- stallions
- wild stallions
- wild stallion
- wyld stallions
- you know the best band in the world wild stallions
malibu_stacey_intent:
- malibu stacy
- malley boo stay see
- malla boo stay see
- what would malibu stacy do
- what wood malley boo stay see do
- what wood malla boo stay see do
- what would malibu stacey say
- talk like malibu stacy
sing_intent:
- sing
- sing me a song
- can you sing
- sing me another song please
- i want you to sing
law_of_robotics.intent:
- what are the laws of robotics
- tell me the laws of robotic
Expand Down
Loading