Repository navigation
fix(dialog): use {stardate} slot syntax in every locale - #122
Conversation
stardate.dialog used '{{ stardate }}' (13 locales) or '{ stardate }'
(eu-ES, gl-ES). Neither renders:
- ovos-utils 0.8.5 (Neon's pin) speaks it literally: 'Stardate { stardate }'
- ovos-utils 0.14 (OVOS-INTENT-2 renderer) raises MalformedTemplate
'{stardate}' renders on both (all 45 lines checked on each). Only the slot
tokens change; no translated wording is touched. Clears the 45 spec-lint
errors.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Checking in! I've finished the automated rounds. 🏥I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthChecking the repository's vital signs. 💓 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckAuditing the legal lineage of this contribution. 📜 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)Scanning for any potential denial-of-service vectors. 🚫 ✅ No known vulnerabilities found (74 packages scanned). 🔍 LintJust keeping you informed on the state of things. ℹ️ ❌ ruff: issues found in 17 file(s) — see job log 🧪 Spec LintI've checked the pulse of your pull request. 💓 ✅ 0 error(s), 1 warning(s) 🎙️ SkillThe skill's performance metrics are looking good. 📈 🎙️ (unknown skill_id) — 15 languages en-US: 17 intents · 13 dialogs · skill.json Translation coverage — 14 languages (11 complete, 3 partial)
🔨 Build TestsThe build pipeline has reached its destination. 📍 ✅ All versions pass
Crafting quality through automation. 🧪 |
stardate.dialog used '{{ stardate }}' (13 locales) or '{ stardate }'
(eu-ES, gl-ES). Neither renders:
- ovos-utils 0.8.5 (Neon's pin) speaks it literally: 'Stardate { stardate }'
- ovos-utils 0.14 (OVOS-INTENT-2 renderer) raises MalformedTemplate
'{stardate}' renders on both (all 45 lines checked on each). Only the slot
tokens change; no translated wording is touched. Clears the 45 spec-lint
errors.
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The stardate easter egg is broken on every OVOS version:
{{ stardate }}/{ stardate }(before)MalformedTemplate{stardate}(after)All 15 locales'
stardate.dialognow use{stardate}: 45 slot tokens changed (39{{ stardate }}, 6{ stardate }in eu-ES/gl-ES), and no translated wording is touched. Every line was rendered on both renderer versions (45/45 each).pytest test: 191 passed, 1 xfailed. This clears the 45 spec-lint errors the PR bot reports on every PR.🤖 Generated with Claude Code