Skip to content

fix(dialog): use {stardate} slot syntax in every locale - #122

Merged
mikejgray merged 1 commit into
devfrom
fix/stardate-slot
Sep 24, 2026
Merged

mikejgray merged 1 commit into
devfrom
fix/stardate-slot

Conversation

@mikejgray

Copy link
Copy Markdown
Collaborator

The stardate easter egg is broken on every OVOS version:

Template ovos-utils 0.8.5 (Neon) ovos-utils 0.14 (current)
{{ stardate }} / { stardate } (before) speaks "Stardate { stardate }" raises MalformedTemplate
{stardate} (after) "Stardate 4 2 7" "Stardate 4 2 7"

All 15 locales' stardate.dialog now use {stardate}: 45 slot tokens changed (39 {{ stardate }}, 6 { stardate } in eu-ES/gl-ES), and no translated wording is touched. Every line was rendered on both renderer versions (45/45 each). pytest test: 191 passed, 1 xfailed. This clears the 45 spec-lint errors the PR bot reports on every PR.

🤖 Generated with Claude Code

stardate.dialog used '{{ stardate }}' (13 locales) or '{ stardate }'
(eu-ES, gl-ES). Neither renders:
- ovos-utils 0.8.5 (Neon's pin) speaks it literally: 'Stardate { stardate }'
- ovos-utils 0.14 (OVOS-INTENT-2 renderer) raises MalformedTemplate

'{stardate}' renders on both (all 45 lines checked on each). Only the slot
tokens change; no translated wording is touched. Clears the 45 spec-lint
errors.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5a82de48-f2bb-48bd-af58-d9d0772edd98


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix label Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Checking in! I've finished the automated rounds. 🏥

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

Checking the repository's vital signs. 💓

✅ All required files present.

Latest Version: 1.2.0a1

✅ version.py — Version file
✅ README.md — README
✅ LICENSE — License file
⚠️ pyproject.toml — pyproject.toml
✅ setup.py — setup.py
✅ CHANGELOG.md — Changelog
⚠️ requirements.txt — Requirements
✅ version.py has valid version block markers

⚖️ License Check

Auditing the legal lineage of this contribution. 📜

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Scanning for any potential denial-of-service vectors. 🚫

✅ No known vulnerabilities found (74 packages scanned).

🔍 Lint

Just keeping you informed on the state of things. ℹ️

❌ ruff: issues found in 17 file(s) — see job log
✅ actionlint: 11 workflow file(s), no finding

🧪 Spec Lint

I've checked the pulse of your pull request. 💓

✅ 0 error(s), 1 warning(s)

🎙️ Skill

The skill's performance metrics are looking good. 📈

🎙️ (unknown skill_id) — 15 languages

en-US: 17 intents · 13 dialogs · skill.json ⚠️

Translation coverage — 14 languages (11 complete, 3 partial)
Language Progress Coverage
ca-ES ██████████ ✅ 100.0% (30/30)
da-DK ██████████ ✅ 100.0% (30/30)
de-DE ████████░░ ⚠️ 83.3% (25/30)
es-ES ██████████ ✅ 100.0% (30/30)
eu-ES █████████░ ⚠️ 86.7% (26/30)
fr-FR ██████████ ✅ 100.0% (30/30)
gl-ES █████████░ ⚠️ 86.7% (26/30)
it-IT ██████████ ✅ 100.0% (30/30)
kab ██████████ ✅ 100.0% (30/30)
nl-NL ██████████ ✅ 100.0% (30/30)
oc-FR ██████████ ✅ 100.0% (30/30)
pt-BR ██████████ ✅ 100.0% (30/30)
pt-PT ██████████ ✅ 100.0% (30/30)
sv-SE ██████████ ✅ 100.0% (30/30)

🔨 Build Tests

The build pipeline has reached its destination. 📍

✅ All versions pass

Python Build Install Tests pytest
3.10 ✅ ✅ ✅ 191 passed, 1 xfailed, 12 warnings in 15.01s
3.11 ✅ ✅ ✅ 191 passed, 1 xfailed, 12 warnings in 17.68s
3.12 ✅ ✅ ✅ 191 passed, 1 xfailed, 12 warnings in 21.33s
3.13 ✅ ✅ ✅ 191 passed, 1 xfailed, 12 warnings in 16.26s
3.14 ✅ ✅ ✅ 191 passed, 1 xfailed, 12 warnings in 14.24s

Crafting quality through automation. 🧪

@mikejgray
mikejgray merged commit 4542156 into dev Sep 24, 2026
17 checks passed
@mikejgray
mikejgray deleted the fix/stardate-slot branch September 24, 2026 04:28
mikejgray added a commit that referenced this pull request Oct 10, 2026
stardate.dialog used '{{ stardate }}' (13 locales) or '{ stardate }'
(eu-ES, gl-ES). Neither renders:
- ovos-utils 0.8.5 (Neon's pin) speaks it literally: 'Stardate { stardate }'
- ovos-utils 0.14 (OVOS-INTENT-2 renderer) raises MalformedTemplate

'{stardate}' renders on both (all 45 lines checked on each). Only the slot
tokens change; no translated wording is touched. Clears the 45 spec-lint
errors.

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant