Repository navigation
fix: answer "how many languages" in query_langs; move the eu-ES singular language - #91
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Checking the status... all automated tasks are done! ✅I've aggregated the results of the automated checks for this PR below. 🧪 Spec LintHere's the report you've been waiting for. 📁 ✅ 0 error(s), 0 warning(s) 🔍 LintEnsuring the codebase remains stable and healthy. 🛡️ ❌ ruff: issues found in 11 file(s) — see job log 🏷️ Release PreviewHere's what the next release might look like! 🚀 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
📋 Repo HealthChecking if we're following maintenance best practices. 📏 ✅ All required files present. Latest Version: ✅ 🎙️ SkillA linguistic and structural check of your skill. 📚 ℹ️ Not an OVOS skill repo — check skipped. 🔒 Security (pip-audit)Checking the vault for any security leaks. 🔓 ✅ No known vulnerabilities found (82 packages scanned). ⚖️ License CheckA detailed legal audit of your PR. 📖 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsA thorough inspection of the build process. 🔍 ✅ All versions pass
🔌 Skill Tests (ovoscope)I ran the end-to-end skill tests to see how your skill behaves in the real world! 🎤 ✅ 65/67 passed ✅ TestM2VDiagnosticsGoldenEffect — 7/7 ❌ **test_golden_rows_match_their_intent[pl-PL]** — 0/1
❌ **test_golden_rows_match_their_intent[ru-RU]** — 0/1
🚌 Bus CoverageEnsuring every intent and event is reached by the test suite. 🎯 📊 CoverageTest coverage audit: no stone left unturned. 🗿 ✅ 91.2% total coverage Per-file coverage (2 files)
Full report: download the Thanks for making OVOS better today! 🙌 |
09445ce to
82fbcfa
Compare
82fbcfa to
f02cdd8
Compare
f02cdd8 to
a3221a4
Compare
a3221a4 to
1f35be7
Compare
1f35be7 to
6fcad7c
Compare
…lar language
The easter egg's languages intent is removed, so query_langs takes over its
phrasings in the 15 locales it covered ("how many languages do you speak",
"languages do you speak", and the per-locale equivalents); each sentence has one
owner across both skills. The eu-ES singular-language sentences ("zein hizkuntza
erabiltzen ari zara", "zein hizkuntzatan hitz egiten duzu") belong to
query_primary_lang. Two easter-egg golden rows move to the en-US golden file.
The pl-PL and ru-RU golden gaps are recorded as strict expected failures for the
published m2v model.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6fcad7c to
b11af11
Compare
The easter egg's "languages" intent conflicted with
query_langs. Diagnostics now owns those phrasings.query_langsin 15 locales, merged into existing alternations.query_primary_lang.Tested: no sentence shared between intents; suite passes. Known gaps recorded for the published model (pl-PL, ru-RU); they flip after retrain.
Merge together with OpenVoiceOS/ovos-skill-easter-eggs#134.
🤖 Generated with Claude Code