Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datastore/dsmodels/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ func getRelationIds(idField reflect.Value, targetField reflect.Value, many bool)
if val, set := id.Value(); set {
ids = append(ids, val)
}
} else if idField.Type().Name() == "Maybe[string]" {
id := idField.Interface().(dsfetch.Maybe[string])
if val, set := id.Value(); set {
fqids = append(fqids, val)
}
}

return ids, fqids
Expand Down
30 changes: 30 additions & 0 deletions datastore/dsmodels/fetch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,3 +279,33 @@ func TestPolymorphicPreload(t *testing.T) {
t.Errorf("res.ContentObject.Title = %s, expected 'foo'", topic.Title)
}
}

func TestPolymorphicPreloadOnNonRequired(t *testing.T) {
ds := dsmodels.New(dsmock.Stub(dsmock.YAMLData(`---
history_entry/1:
position_id: 1
meeting_id: 1
model_id: motion/1
motion/1:
sequential_number: 1
title: foo
meeting_id: 1
list_of_speakers_id: 1
state_id: 1
`)))

hQ := ds.HistoryEntry(1)
res, err := hQ.Preload(hQ.Model()).First(t.Context())
if err != nil {
t.Errorf("HistoryEntry 1 with motion returned unexpected error: %v", err)
}

motion, isMotion := res.Model.(*dsmodels.Motion)
if !isMotion {
t.Errorf("type of res.Model = %s, expected *dsmodels.Motion", reflect.TypeOf(res.Model))
}

if motion.Title != "foo" {
t.Errorf("res.Model.Title = %s, expected 'foo'", motion.Title)
}
}
Loading