Skip to content

fix(plugin): stop the editor aborting the host on Windows #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OpenSauce merged 4 commits into from
Jul 27, 2026
Merged

fix(plugin): stop the editor aborting the host on Windows #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1739959
fix(plugin): stop the editor aborting the host on Windows
OpenSauce Jul 27, 2026
b0b4b5d
fix(plugin): redraw the editor continuously to stop it flickering
OpenSauce Jul 27, 2026
0e62925
Revert "fix(plugin): redraw the editor continuously to stop it flicke…
OpenSauce Jul 27, 2026
ad1df4a
build(plugin): pin iced_baseview to the fork's v0.1.0 tag
OpenSauce Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ Nothing to add in `rustortion-plugin/src/params.rs` — stage parameters are not
- **IR files** live in `impulse_responses/` and `~/.config/rustortion/impulse_responses/`; loading
is async, off the RT thread. Keep convolver type configurable — FIR beat FFT on the Pi in real
testing, and the TwoStage tail math is numerically wrong until REV-2 lands.
- **iced_baseview** is a fork at `github.com/OpenSauce/iced_baseview` (unpinned git dep).
- **iced_baseview** is a fork at `github.com/OpenSauce/iced_baseview`, pinned to tag `v0.1.0`.
Moving it means tagging a release on the fork first — don't repoint it at a bare `rev`.
- **The plugin exposes 9 global params only** (`params.rs`, ~117 lines): output level, IR gain/bypass,
pitch shift, HP/LP enable+cutoff, preset index. The nested per-slot param arrays were deleted in
REV-4 — they were never read by `process()`. Stage settings travel through `chain_state` (preset
Expand Down
15 changes: 8 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rustortion-plugin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ crate-type = ["cdylib"]
rustortion-core = { path = "../rustortion-core" }
nih_plug = { git = "https://github.com/robbert-vdh/nih-plug.git", rev = "28b149ec" }
rustortion-ui = { path = "../rustortion-ui" }
iced_baseview = { git = "https://github.com/OpenSauce/iced_baseview.git", rev = "2377031b" }
iced_baseview = { git = "https://github.com/OpenSauce/iced_baseview.git", tag = "v0.1.0" }
crossbeam = "0.8"
log = "0.4"
dirs = "6"
Expand Down