Feat: lengkapi detail pembangunan#1664
Open
pandigresik wants to merge 3 commits into
Open
Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Lengkapi Detail Pembangunan dengan Informasi Anggaran, Volume, Tahun, dan Pelaksana
Description
Menambahkan informasi yang lebih lengkap pada halaman detail pembangunan. Sebelumnya hanya menampilkan nama kegiatan, sumber dana, lokasi, dan keterangan. PR ini menambahkan 4 field baru: Anggaran, Volume, Tahun Anggaran, dan Pelaksana Kegiatan.
Changes made:
resources/views/data/pembangunan/gabungan/rincian.blade.phpresources/views/data/pembangunan/rincian.blade.phpReason for change:
Impact of change:
✅ User Experience: Pengguna mendapatkan informasi lebih lengkap dalam satu halaman
✅ Konsistensi: Kedua halaman rincian pembangunan (gabungan dan non-gabungan) menampilkan informasi yang sama
✅ Komprehensif: Detail proyek mencakup aspek finansial (anggaran), teknis (volume), temporal (tahun), dan kelembagaan (pelaksana)
Related Issue
Steps to Reproduce
Before fix (problem):
After fix (solution):
Testing on related features:
Checklist
Technical Details
Technical Explanation
Penambahan 4 field baru pada halaman rincian pembangunan:
File:
resources/views/data/pembangunan/gabungan/rincian.blade.php<tr>baru untuk Anggaran, Volume, Tahun, dan Pelaksanaresponse.data.attributesuntuk mengisi data via AJAXRp. ${Number(value).toLocaleString('id-ID')}?? '-'untuk field yang kosongFile:
resources/views/data/pembangunan/rincian.blade.php<tr>baru dengan Blade syntax{{ }}format_number_id()untuk format anggaranConfiguration changes
Tidak ada perubahan konfigurasi
Dependencies added
Tidak ada dependency baru
Testing
Manual Testing
Screenshots / Video
Before:
Hanya menampilkan: Nama Kegiatan, Sumber Dana, Lokasi Pembangunan, Keterangan
After:
Menampilkan: Nama Kegiatan, Sumber Dana, Anggaran (Rp), Volume, Tahun, Pelaksana, Lokasi Pembangunan, Keterangan
Breaking Changes
None
Migration Guide
Not required
References
Additional notes: PR ini merupakan perubahan UI-only (view layer), tidak ada perubahan backend atau database. Data anggaran, volume, tahun, dan pelaksana sudah tersedia dari API yang ada.