Perbaiki fungsi dokumen saat ini tidak di tampilkan dengan benar - #1662
Merged
Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue # #1654
🎯 Deskripsi
Pull request ini memperbaiki halaman publik Dokumen Formulir (
/unduhan/form-dokumen) agar dapat menampilkan dokumen secara komprehensif dan interaktif, menyelaraskan konsistensi antarmuka dengan halaman Regulasi dan Prosedur.Penyebab utama dari issue sebelumnya antara lain:
Dengan PR ini, antarmuka daftar tabel telah disederhanakan, interaksi pada tombol diperjelas, dan pemanggilan modal dirancang untuk merender preview dokumen beserta seluruh kelengkapan detail atribut yang direquest dari sisi API.
🛠️ Perubahan yang Dilakukan
1.
themes/opendk/default/resources/views/pages/unduhan/form-dokumen.blade.phpFix — Pembaruan UI, Tombol, dan Implementasi Modal:
<a>biasa dan icon mata menjadi tombol interaktif berlabel "Lihat Dokumen".showDokumenDetail(id)untuk memanggil HTTP Request melalui AJAX dan merender susunan Bootstrap Modal secara dinamis—mencakup baris-baris informasi Jenis, Deskripsi, Tanggal Terbit, Waktu Retensi, serta penyiapan elemen IFRAME/IMG untuk fitur preview file.2.
app/Repositories/FormDokumenApiRepository.phpFix — Penambahan Filter ID API:
AllowedFilter::exact('id')pada allowedFilters repositori guna memfasilitasi fetching detail single-item melalui Endpoint JSON secara tepat (?filter[id]=...) saat modal diklik.3.
app/Transformers/FormDokumenTransformer.phpFix — Eksposure Data Atribut Tambahan:
description,retention_days,published_at,expired_at).mime_typedengan verifikasi fungsiis_file()sehingga tipe media (application/pdf atau image dapat dipilah langsung oleh skrip klien sebagai iframe atau image.✅ Test Cases yang Diimplementasikan
/unduhan/form-dokumen, tabel DataTables berhasil tampil dengan jumlah kolom yang sudah sesuai (tanpa ada kolom Status).📸 Cara Menjalankan Uji Coba Manual
/unduhan/form-dokumen.📸 Screenshot atau Video