Sesuaikan UI/UX di Modul Event#1643
Open
habibie11 wants to merge 9 commits into
Open
Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
Contributor
|
Untuk standar tombol (mengacu PR #1633), perbaikan harus mengikuti standar tersebut agar konsistensi UI: Gunakan komponen standar (bukan forms/aksi-grup.blade.php custom). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #1627
🎯 Deskripsi
Pull request ini difokuskan pada penyeragaman standar UI (User Interface) di modul Event (
/informasi/event) agar selaras dengan modul lainnya (seperti Prosedur), serta merombak sistem pratinjau (preview) event. Berdasarkan permintaan, pratinjau dokumen internal (popup/modal) yang sering memicu isu dihilangkan dan diganti sepenuhnya menjadi direct access ke Web Publik melalui tautan tab baru.Perbaikan ini mencegah redundansi komponen dan memastikan konsistensi antarmuka unggahan lampiran agar lebih responsif terhadap nama file yang membludak (panjang).
🛠️ Perubahan yang Dilakukan
1. Refaktor Pratinjau Event (Tab Baru Publik)
informasi.event.previewdiweb.phpuntuk menonaktifkan fitur pratinjau berbasis modal (popup) yang dinilai kurang efektif.show_web(membuka di tab baru), yang me-redirect admin langsung ke URL halaman depan publik (event.detail).2. Standarisasi Komponen Unggah File
form_create.blade.phpdanform_edit.blade.phpuntuk memakai atribut CSS layout statis standar (memilikifloat:lefttanpa disisipkan secara inline dari JS secara berulang).overflow: hidden;sertaword-break: break-all;demi mencegah batas wadah robek oleh string panjang nama file.3. Optimalisasi Tabel Data
forms.aksi-grup.blade.php(berisi menu dropdown rapi).4. Perbaikan Testing Browser
SmokeInformasiTest.phpagar mampu mendeteksi pergantian parameter dari fungsi "Lihat" (dari awalnya mencari identifierbtn-lihatmenjadibtn-lihat-web). Hal ini dikarenakan Event kini menggunakan parameter buka Tab Baru ke frontend publik.✅ Test Cases yang Diimplementasikan
event.detail) di tab baru. Test browserSmokeInformasiTest.phpkini ter-resolusi sempurna dengan kustomisasi identifikasi elemen.