com4FlowPy: variable raster value validation - #1328
Merged
Merged
Conversation
Contributor
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
MunsMan
force-pushed
the
HM_com4_input_validation
branch
from
August 17, 2026 17:09
0981a0b to
960467c
Compare
MunsMan
force-pushed
the
HM_com4_input_validation
branch
from
August 18, 2026 09:17
aa4eee7 to
d3fa467
Compare
fso42
requested changes
Aug 18, 2026
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
fso42
approved these changes
Aug 19, 2026
PaulaSp3
reviewed
Aug 25, 2026
ahuber-bfw
force-pushed
the
HM_com4_input_validation
branch
from
August 26, 2026 12:12
a982070 to
8648719
Compare
ahuber-bfw
requested changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Hab's noch ein bisschen umstrukturiert
- die "valid parameter ranges" aus dem .ini entfernt und in eine extra funktion gegeben, wo sie bei Bedarf angepasst werden können (außer die limits für max_u und max_z macht eine user-Anpassung aber wenig bis keinen Sinn, weil mit anderen Wertebereichen dann entweder numerisch Probleme auftauchen, bzw. diese auch einfach keinen Sinn ergeben)
- die sys.exit(1) durch raise ValueError ersetzt
was noch fehlt:
- pytests für die neuen funktionen zusätzlich zu
validateInputArray()(mach ich noch bevor ich die pytest und doku häkchen setze)
für später:
- Entsprechende Anpassung der anderen hard exits mit sys.exit() bei Zeit und Muße
PaulaSp3
approved these changes
Aug 26, 2026
PaulaSp3
approved these changes
Aug 31, 2026
PaulaSp3
force-pushed
the
HM_com4_input_validation
branch
2 times, most recently
from
August 31, 2026 08:18
1c5fa98 to
63dc1b8
Compare
- improved roved input parameter/data checks for com4FlowPy - fix(com4FlowPy): defining default as fallback - add(com4FlowPy) raster value validation - refactor array validation - add (test) array validation - fixing pra detection - moving limit into cfg - updating to python conventions - releasePath to releasePathWork - fixes pytest issue with .shp input re-structuring input paramter check and raising ValueError instead of sys.exit(1) f strings in check function consistently import suggestions Paula for added com4FlowPy pytest expose valid parameter limits in .ini minor formatting fix add tests
fso42
force-pushed
the
HM_com4_input_validation
branch
from
September 1, 2026 10:00
63dc1b8 to
aefc2ce
Compare
Contributor
|
Standardtests ident, apart from known com5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to improve the input validation.
Validates the variable input rasters (alpha, umax) before the simulation.
closes #1327
This implementation currently breakes:
avaframe/tests/test_com4FlowPy.py::test_runCom4FlowPywith:
rasterio.errors.RasterioIOError: '/private/var/folders/57/n7xtvxg905j6tywq55t9..PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master