[ana5]: add general thalweg extension & resampling - #1323
Merged
Conversation
7 tasks
14 tasks
Contributor
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (3)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
3 times, most recently
from
August 13, 2026 11:26
ea6399c to
da66642
Compare
fso42
requested changes
Aug 14, 2026
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
August 20, 2026 09:19
da66642 to
7840ce0
Compare
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
2 times, most recently
from
August 24, 2026 16:40
a41f2bf to
673066c
Compare
fso42
approved these changes
Aug 25, 2026
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
August 26, 2026 08:39
673066c to
7aef947
Compare
awirb
requested changes
Aug 31, 2026
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
August 31, 2026 13:27
521888f to
8f6319e
Compare
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
September 1, 2026 06:21
c171055 to
1170454
Compare
awirb
approved these changes
Sep 1, 2026
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
September 1, 2026 11:28
e5368b5 to
8643d80
Compare
resample path comments FSO correct comment adapt test comments AW adapt dou fix typo Co-authored-by: Anna Wirbel <68687423+awirb@users.noreply.github.com> move extension with direction into separate function can compute extension for 2 points use parameter from ini file adapt tests; config ini
PaulaSp3
force-pushed
the
PS_FP_thalweg
branch
from
September 1, 2026 11:36
8643d80 to
4a931c4
Compare
Contributor
|
Standardtests ok, apart from known com5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The goal is to derive a thalweg profile from very general thalweg data (containing x and y coordinates).
This changed in each file:
ana5Utils/DFAPathGeneration.py:
(for option 2, the code is very similar as in extendProfileBottom, should we summarize both in one function with options/different handling for top nd bottom extension?)
ana5Utils/DFAPathGenerationCfg.ini:
ana5Utils/preparePathGeneral.py
functions to prepare a path/thalweg that has only x and y coordinates:
out3Plot/outCom3Plots.py
PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master