fix(115-open): handle missing path info#2563
Conversation
|
请使用正确的PR模板 |
jyxjjj
left a comment
There was a problem hiding this comment.
这里的改动属于过度封装:没有真正解决原问题,而是通过新增抽象把问题绕过去了。这样会增加理解和维护成本,也可能掩盖底层缺陷。
建议直接修复根因,而不是引入额外封装来规避问题。
另外,根据代码风格特征以及未使用 PR 模板的情况,该 PR 存在较高概率使用了 AI 辅助生成内容。在继续评审前,请先按照我们的 AI Disclosure Policy 完成相应披露。
|
建议考虑是否可以从 SDK 侧修复,而非在 OpenList Driver 中单独实现兼容逻辑。这样不仅能够让所有调用方共享修复结果,也能避免相同问题未来在其他位置重复出现。 Zhu 本身也是我们的 Core Dev 之一,我已经将他指派到该 PR。建议先尝试向对应 SDK 仓库提交修复并完成合并,再回到 OpenList 更新依赖解决此问题。 |
|
Thanks for the review. You are right that this should be fixed in AI disclosure: this PR was prepared with substantial assistance from OpenAI Codex. Scope: code change, issue reproduction summary, and PR description drafting. I reviewed the generated change and verified it with I will move the root-cause fix to |
|
SDK-side root-cause fix has been submitted here: This PR should not continue with the current driver-side workaround. After the SDK fix is reviewed/merged and a usable SDK version is available, I will update this OpenList PR to remove the driver-side response parsing code and only bump |
Co-authored-by: OpenAI Codex <codex@openai.com>
6d5b60f to
451bc62
Compare
|
The SDK-side fix has been merged and released as This PR has been updated accordingly:
@jyxjjj @SheltonZhu could you please re-review when convenient? The previous |
Summary / 摘要
Update
github.com/OpenListTeam/115-sdk-gotov0.2.4, which fixes path-based/open/folder/get_inforesponses where 115 returnsdataas an array.OpenList now maps the SDK-level
sdk.ErrObjectNotFoundto OpenList's internalerrs.ObjectNotFound, sointernal/op.MakeDircan continue past the existence check and call the actual mkdir API./ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Fixes #2562
Testing / 测试
go test ./...v4.2.2via/api/fs/getand/api/fs/mkdiragainst a missing/115open/...path./115openpaths still resolve via/api/fs/get.go list -m github.com/OpenListTeam/115-sdk-goand confirmedv0.2.4.gofmt -w drivers/115_open/driver.go.git diff --check.go testwas not run locally because the local task constraint forbids generating compiled test artifacts/caches. No project binary build was performed.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt,go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。