Skip to content

OpenConceptLab/ocl_issues#2480 | clone operation everything or nothing#857

Merged
snyaggarwal merged 2 commits intomasterfrom
issues#2480
Apr 23, 2026
Merged

OpenConceptLab/ocl_issues#2480 | clone operation everything or nothing#857
snyaggarwal merged 2 commits intomasterfrom
issues#2480

Conversation

@snyaggarwal
Copy link
Copy Markdown
Contributor

Linked Issue

Closes OpenConceptLab/ocl_issues#2480

@snyaggarwal snyaggarwal requested a review from paynejd April 20, 2026 06:54
@paynejd
Copy link
Copy Markdown
Member

paynejd commented Apr 22, 2026

Flagging a regression risk spotted during review:

This PR adds except CloneError handling to SourceConceptsCloneView.post in core/sources/views.py (L400-402), but ConceptCloneView.post in core/concepts/views.py (L471-474) also calls Bundle.clone(...) and doesn't catch CloneError.

Before this PR, a failed clone through that endpoint silently succeeded. After this PR, it will raise an uncaught CloneError and surface as HTTP 500 — a behavioral regression on that entry point.

Suggest mirroring the same try/except CloneError block so both $clone entry points return the structured 400 response consistently.

@snyaggarwal snyaggarwal merged commit f4ad8eb into master Apr 23, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$clone operation everything or nothing

2 participants