Skip to content

fix(ci): use local commit python for node python (#17488) - #17519

Merged
A. Jard (aHenryJard) merged 5 commits into
masterfrom
issue/17488-node-python
Aug 6, 2026
Merged

fix(ci): use local commit python for node python (#17488)#17519
A. Jard (aHenryJard) merged 5 commits into
masterfrom
issue/17488-node-python

Conversation

@aHenryJard

@aHenryJard A. Jard (aHenryJard) commented Aug 5, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • local (from commit) client-python is already used for worker build, need to be use for node python build too to avoid inconsistency on Pull request with new feature of python.

Note: local client python = false is not used much today, but it will when all the release process will be on github.

Related issues

How to test this PR

No sure... CI is green ?

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant use cases (coverage and e2e)
  • I added/updated the relevant documentation (either on GitHub or on Notion)
  • Where necessary, I refactored code to improve the overall quality

Further comments

Copilot AI lite review requested due to automatic review settings August 5, 2026 08:59
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows so the backend’s embedded Python dependencies can use the client-python code from the same OpenCTI commit/branch during CI and image builds, reducing mismatches between platform code and the pycti client it installs.

Changes:

  • Add a client_python_local input to ci-test-backend.yml and rewrite opencti-graphql/src/python/requirements.txt to install pycti from the same OpenCTI ref when enabled.
  • Enable client_python_local in ci-main.yml when calling the backend test workflow.
  • Modify feature-branch deployment workflow input default for client_python_local, and update rolling image build workflow to rewrite pycti to a git-based dependency.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test-feature-branch.yml Changes the default behavior for using local client-python during feature-branch deployments.
.github/workflows/ci-test-backend.yml Adds an input + step to force backend tests to use pycti from the same OpenCTI ref.
.github/workflows/ci-main.yml Passes client_python_local: true into the backend test reusable workflow.
.github/workflows/cd-build-rolling-images-on-merge.yml Rewrites pycti dependency to a git URL for rolling builds on merge.
Suppressed comments (1)

.github/workflows/ci-test-backend.yml:292

  • This job uses inputs.checkout_ref to install pycti from Git, but the checkout step doesn’t use inputs.checkout_ref. If a caller provides a different ref, the workspace and the installed client version can be inconsistent. Add with.ref: ${{ inputs.checkout_ref }} to the checkout step.
    - name: Use client-python in OpenCTI from same branch
      if: ${{ inputs.client_python_local == true }}
      run: sed -i 's|^pycti==.*$|pycti @ git+https://github.com/OpenCTI-Platform/opencti@${{ inputs.checkout_ref }}#subdirectory=client-python|' ./opencti-platform/opencti-graphql/src/python/requirements.txt

Comment thread .github/workflows/test-feature-branch.yml Outdated
Comment thread .github/workflows/cd-build-rolling-images-on-merge.yml
Comment thread .github/workflows/ci-test-backend.yml Outdated
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.13%. Comparing base (89d463c) to head (3223f47).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17519      +/-   ##
==========================================
+ Coverage   34.12%   34.13%   +0.01%     
==========================================
  Files        3376     3376              
  Lines      137671   137826     +155     
  Branches    37258    37338      +80     
==========================================
+ Hits        46978    47048      +70     
- Misses      90693    90778      +85     
Flag Coverage Δ
opencti-client-python 48.37% <ø> (ø)
opencti-front 11.14% <ø> (+0.06%) ⬆️
opencti-graphql 69.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aHenryJard
A. Jard (aHenryJard) merged commit c0c7d50 into master Aug 6, 2026
55 checks passed
@aHenryJard
A. Jard (aHenryJard) deleted the issue/17488-node-python branch August 6, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): pycti should be local also for python inside platfrom src

3 participants