Skip to content

fix(web): refine agent actions menu styles #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youngbeom-shin merged 1 commit into from
Aug 11, 2026
Merged

fix(web): refine agent actions menu styles #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions web/app/src/components/ui/DropdownMenu/DropdownMenu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
display: flex;
min-height: 38px;
align-items: center;
justify-content: space-between;
justify-content: flex-start;
gap: 12px;
padding: 8px 10px;
border-radius: 8px;
Expand All @@ -27,12 +27,20 @@
user-select: none;
}

.csg-dropdown-menu-item svg {
flex: 0 0 auto;
}

.csg-dropdown-menu-item:hover,
.csg-dropdown-menu-item[data-highlighted] {
background: var(--primary-soft);
color: var(--text);
}

.csg-dropdown-menu-item:active {
background: color-mix(in oklab, var(--primary) 14%, transparent);
}

.csg-dropdown-menu-checkbox-item {
position: relative;
padding-left: 32px;
Expand All @@ -50,14 +58,32 @@
line-height: 1;
}

.csg-dropdown-menu-item.warning {
color: var(--warning);
}

.csg-dropdown-menu-item.warning:hover,
.csg-dropdown-menu-item.warning[data-highlighted] {
background: color-mix(in oklab, var(--warning) 12%, transparent);
color: color-mix(in oklab, var(--warning) 90%, var(--text));
}

.csg-dropdown-menu-item.warning:active {
background: color-mix(in oklab, var(--warning) 18%, transparent);
}

.csg-dropdown-menu-item.danger {
color: var(--danger);
}

.csg-dropdown-menu-item.danger:hover,
.csg-dropdown-menu-item.danger[data-highlighted] {
background: var(--error-50);
color: var(--danger);
background: color-mix(in oklab, var(--danger) 12%, transparent);
color: color-mix(in oklab, var(--danger) 90%, var(--text));
}

.csg-dropdown-menu-item.danger:active {
background: color-mix(in oklab, var(--danger) 18%, transparent);
}

.csg-dropdown-menu-item[data-disabled] {
Expand All @@ -66,6 +92,13 @@
pointer-events: none;
}

.csg-dropdown-menu-item[data-disabled]:hover,
.csg-dropdown-menu-item[data-disabled][data-highlighted],
.csg-dropdown-menu-item[data-disabled]:active {
background: transparent;
color: var(--muted);
}

.csg-dropdown-menu-separator {
height: 1px;
margin: 5px 4px;
Expand Down
9 changes: 7 additions & 2 deletions web/app/src/components/ui/DropdownMenu/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,21 @@ export const DropdownMenuContent = forwardRef<ComponentRef<typeof RadixDropdownM
},
);

export type DropdownMenuItemTone = "default" | "warning" | "danger";

export type DropdownMenuItemProps = ComponentPropsWithoutRef<typeof RadixDropdownMenu.Item> & {
danger?: boolean;
tone?: DropdownMenuItemTone;
};

export const DropdownMenuItem = forwardRef<ComponentRef<typeof RadixDropdownMenu.Item>, DropdownMenuItemProps>(
function DropdownMenuItem({ className, danger = false, ...props }, ref) {
function DropdownMenuItem({ className, danger = false, tone, ...props }, ref) {
const itemTone = tone ?? (danger ? "danger" : "default");

return (
<RadixDropdownMenu.Item
ref={ref}
className={classNames("csg-dropdown-menu-item", danger && "danger", className)}
className={classNames("csg-dropdown-menu-item", itemTone !== "default" && itemTone, className)}
{...props}
/>
);
Expand Down
1 change: 1 addition & 0 deletions web/app/src/pages/AgentPage/components/AgentDetailPane/AgentDetailPane.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@
}

.agent-actions-menu-badge {
margin-left: auto;
padding: 2px 6px;
border-radius: var(--radius-full);
background: var(--warning-50);
Expand Down
29 changes: 22 additions & 7 deletions web/app/src/pages/AgentPage/components/AgentDetailPane/AgentDetailPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ import {
FileCode2,
Link2,
MoreHorizontal,
Play,
Plus,
RefreshCw,
Save,
Server,
Square,
Trash2,
Unlink2,
UploadCloud,
UserPlus,
} from "lucide-react";
import { forwardRef, useCallback, useEffect, useImperativeHandle, useMemo, useRef, useState } from "react";
import { errorMessage } from "@/api/client";
Expand Down Expand Up @@ -2008,29 +2013,38 @@ function AgentActionsMenu({
<DropdownMenuContent className="agent-actions-menu" aria-label={t("agentMoreActions")}>
{SHOW_AGENT_LIFECYCLE_ACTIONS ? (
<DropdownMenuItem disabled={busy || incomplete} onSelect={() => (running ? onStop(item) : onStart(item))}>
{running ? t("agentStop") : t("agentStart")}
{running ? (
<Square aria-hidden="true" size={15} strokeWidth={2} />
) : (
<Play aria-hidden="true" size={15} strokeWidth={2} />
)}
<span>{running ? t("agentStop") : t("agentStart")}</span>
</DropdownMenuItem>
) : null}
<DropdownMenuItem danger disabled={busy || incomplete} onSelect={() => onRecreate(item)}>
{t("agentRecreate")}
<DropdownMenuItem disabled={busy || incomplete} onSelect={() => onRecreate(item)}>
<RefreshCw aria-hidden="true" size={15} strokeWidth={2} />
<span>{t("agentRecreate")}</span>
</DropdownMenuItem>
{SHOW_AGENT_LIFECYCLE_ACTIONS && activeRoom && !isManager ? (
<DropdownMenuItem disabled={busy} onSelect={() => onInvite(item)}>
{t("inviteToRoom")}
<UserPlus aria-hidden="true" size={15} strokeWidth={2} />
<span>{t("inviteToRoom")}</span>
</DropdownMenuItem>
) : null}
{canPublishLocal ? (
<>
<DropdownMenuItem disabled={publishBusy} onSelect={() => onPublish?.("local")}>
{publishBusy ? t("agentPublishing") : t("agentSaveLocalTemplate")}
<Save aria-hidden="true" size={15} strokeWidth={2} />
<span>{publishBusy ? t("agentPublishing") : t("agentSaveLocalTemplate")}</span>
</DropdownMenuItem>
{canPublishCommunity ? (
<DropdownMenuItem
disabled={publishBusy || publishDisabled}
title={publishDisabled ? t("agentPublishLoginRequired") : undefined}
onSelect={() => onPublish?.("official")}
>
{publishBusy ? t("agentPublishing") : t("agentPublishCommunity")}
<UploadCloud aria-hidden="true" size={15} strokeWidth={2} />
<span>{publishBusy ? t("agentPublishing") : t("agentPublishCommunity")}</span>
</DropdownMenuItem>
) : null}
</>
Expand All @@ -2039,7 +2053,8 @@ function AgentActionsMenu({
<>
<DropdownMenuSeparator />
<DropdownMenuItem danger disabled={busy} onSelect={() => onDelete(item)}>
{t("agentDelete")}
<Trash2 aria-hidden="true" size={15} strokeWidth={2} />
<span>{t("agentDelete")}</span>
</DropdownMenuItem>
</>
) : null}
Expand Down
Loading