Skip to content

Update undici in typescript client generator to newer version - #25445

Merged
wing328 merged 1 commit into
masterfrom
update-ts-undici
Oct 28, 2026
Merged

wing328 merged 1 commit into
masterfrom
update-ts-undici

Conversation

@wing328

@wing328 wing328 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

to close #25444

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Bumps undici to ^7.30.1 in the TypeScript client generator template and the regenerated sample package.json files, closing the referenced PR.

Written for commit 8d8526a. Summary will update on new commits.

View guided diff Turn on auto-fix

@wing328
wing328 marked this pull request as ready for review October 28, 2026 08:39

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/openapi3/client/petstore/typescript/builds/inversify/package.json">

<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/inversify/package.json:35">
P3: `package.json` now requires `undici` `^7.30.1`, but this sample's `package-lock.json` still pins `7.29.0` with a `^7.29.0` root spec. `npm ci` will reject the mismatch, so regenerate the lock with `npm install` in this sample and commit the updated `package-lock.json`.</violation>
</file>

<file name="samples/openapi3/client/petstore/typescript/builds/default/package.json">

<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/default/package.json:35">
P2: `package-lock.json` still declares and resolves `undici` 7.29.1. Regenerate and commit that lockfile; otherwise `npm ci` rejects this package because the dependency range is now `^7.30.1`.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

},
"dependencies": {
"undici": "^7.29.1",
"undici": "^7.30.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: package-lock.json still declares and resolves undici 7.29.1. Regenerate and commit that lockfile; otherwise npm ci rejects this package because the dependency range is now ^7.30.1.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/openapi3/client/petstore/typescript/builds/default/package.json, line 35:

<comment>`package-lock.json` still declares and resolves `undici` 7.29.1. Regenerate and commit that lockfile; otherwise `npm ci` rejects this package because the dependency range is now `^7.30.1`.</comment>

<file context>
@@ -32,7 +32,7 @@
   },
   "dependencies": {
-    "undici": "^7.29.1",
+    "undici": "^7.30.1",
     "@types/node": "^20.17.10",
     "form-data": "^4.0.4",
</file context>

},
"dependencies": {
"undici": "^7.29.1",
"undici": "^7.30.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: package.json now requires undici ^7.30.1, but this sample's package-lock.json still pins 7.29.0 with a ^7.29.0 root spec. npm ci will reject the mismatch, so regenerate the lock with npm install in this sample and commit the updated package-lock.json.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/openapi3/client/petstore/typescript/builds/inversify/package.json, line 35:

<comment>`package.json` now requires `undici` `^7.30.1`, but this sample's `package-lock.json` still pins `7.29.0` with a `^7.29.0` root spec. `npm ci` will reject the mismatch, so regenerate the lock with `npm install` in this sample and commit the updated `package-lock.json`.</comment>

<file context>
@@ -32,7 +32,7 @@
   },
   "dependencies": {
-    "undici": "^7.29.1",
+    "undici": "^7.30.1",
     "@types/node": "^20.17.10",
     "form-data": "^4.0.4",
</file context>

@wing328
wing328 merged commit 046164f into master Oct 28, 2026
44 checks passed
@wing328
wing328 deleted the update-ts-undici branch October 28, 2026 08:51
@wing328 wing328 added this to the 7.27.0 milestone Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant