Repository navigation
Update undici in typescript client generator to newer version - #25445
Merged
Merged
Conversation
wing328
marked this pull request as ready for review
October 28, 2026 08:39
Contributor
There was a problem hiding this comment.
2 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/openapi3/client/petstore/typescript/builds/inversify/package.json">
<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/inversify/package.json:35">
P3: `package.json` now requires `undici` `^7.30.1`, but this sample's `package-lock.json` still pins `7.29.0` with a `^7.29.0` root spec. `npm ci` will reject the mismatch, so regenerate the lock with `npm install` in this sample and commit the updated `package-lock.json`.</violation>
</file>
<file name="samples/openapi3/client/petstore/typescript/builds/default/package.json">
<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/default/package.json:35">
P2: `package-lock.json` still declares and resolves `undici` 7.29.1. Regenerate and commit that lockfile; otherwise `npm ci` rejects this package because the dependency range is now `^7.30.1`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| }, | ||
| "dependencies": { | ||
| "undici": "^7.29.1", | ||
| "undici": "^7.30.1", |
Contributor
There was a problem hiding this comment.
P2: package-lock.json still declares and resolves undici 7.29.1. Regenerate and commit that lockfile; otherwise npm ci rejects this package because the dependency range is now ^7.30.1.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/openapi3/client/petstore/typescript/builds/default/package.json, line 35:
<comment>`package-lock.json` still declares and resolves `undici` 7.29.1. Regenerate and commit that lockfile; otherwise `npm ci` rejects this package because the dependency range is now `^7.30.1`.</comment>
<file context>
@@ -32,7 +32,7 @@
},
"dependencies": {
- "undici": "^7.29.1",
+ "undici": "^7.30.1",
"@types/node": "^20.17.10",
"form-data": "^4.0.4",
</file context>
| }, | ||
| "dependencies": { | ||
| "undici": "^7.29.1", | ||
| "undici": "^7.30.1", |
Contributor
There was a problem hiding this comment.
P3: package.json now requires undici ^7.30.1, but this sample's package-lock.json still pins 7.29.0 with a ^7.29.0 root spec. npm ci will reject the mismatch, so regenerate the lock with npm install in this sample and commit the updated package-lock.json.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/openapi3/client/petstore/typescript/builds/inversify/package.json, line 35:
<comment>`package.json` now requires `undici` `^7.30.1`, but this sample's `package-lock.json` still pins `7.29.0` with a `^7.29.0` root spec. `npm ci` will reject the mismatch, so regenerate the lock with `npm install` in this sample and commit the updated `package-lock.json`.</comment>
<file context>
@@ -32,7 +32,7 @@
},
"dependencies": {
- "undici": "^7.29.1",
+ "undici": "^7.30.1",
"@types/node": "^20.17.10",
"form-data": "^4.0.4",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to close #25444
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Bumps
undicito^7.30.1in the TypeScript client generator template and the regenerated samplepackage.jsonfiles, closing the referenced PR.Written for commit 8d8526a. Summary will update on new commits.