Skip to content

[JAVA][FEIGN] Remove deprecated QueryMap encoded parameter - #25317

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
ReillyBrogan:feign-encoded
Oct 20, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
ReillyBrogan:feign-encoded

Conversation

@ReillyBrogan

@ReillyBrogan ReillyBrogan commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

encoded has been deprecated since Feign 10.7 (Nov 2019) and no longer does anything.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (@KannaKim @martin-mfg @lwlee2608 )

Summary by cubic

Removes the deprecated encoded attribute from @QueryMap annotations in generated Feign clients. The attribute has been a no-op since Feign 10.7 (Nov 2019), so query parameter handling is unchanged.

Written for commit 1833d92. Summary will update on new commits.

View guided diff

`encoded` has been deprecated since Feign 10.7 (Nov 2019) and no longer does anything.

Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

View guided diff | Re-trigger cubic

@wing328
wing328 merged commit 31c062f into OpenAPITools:master Oct 20, 2026
101 checks passed
@wing328

wing328 commented Oct 20, 2026

Copy link
Copy Markdown
Member

thanks for the PR which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants