Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 87 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
|
The JAX-RS sample CI jobs are currently failing during Maven initialization due to a Develocity Maven extension error ( The failure occurs before any Maven goals are executed ( The new This appears to be a CI environment issue rather than a JSON-B compilation failure. |
I'll try to fix/workaround it shortly. Thanks for the PR |
|
Update: I found and applied a workaround for the remaining CI failure. The issue was caused by the GitHub Actions runner using Maven 3.10.0. Its Maven Resolver 2.x no longer provides I reproduced the failure on upstream master, confirming that it is unrelated to the JSON-B changes. Fix applied: I updated Local verification:
The workaround is included in this PR to restore CI compatibility. Since the underlying issue also affects upstream master, I'm happy to separate the CI change if preferred. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #4104
Description
Adds JSON-B as an optional serialization library for the
jaxrs-specgenerator.Jackson remains the default serialization library to preserve backward compatibility.
The implementation includes:
serializationLibrary: jsonbsupport forjaxrs-specTests
The JAX-RS Spec generator tests and the added JSON-B regression tests have been run successfully.
After rebasing onto the current
master:Tests run: 193, Failures: 0, Errors: 0, Skipped: 0Reviewers
Java Technical Committee: @jfiala @cbornet @martin-mfg
Feedback and review are welcome.
Acknowledgements
This contribution was developed as part of my work at software4production.
PR checklist
Summary by cubic
Adds JSON-B as an opt-in serialization library for the
jaxrs-specgenerator. Jackson remains the default, so existing generated output is unchanged.New Features
serializationLibrary: jsonbgenerates models with JSON-B annotations (@JsonbProperty,@JsonbCreator) and JSON-B/JSON-P dependencies for both Jakarta (jakarta.*) and legacy (javax.*) packages.Behavior change
JavaJAXRSCXFCDIServerCodegenalways uses Jackson, so it now removes theserializationLibraryoption instead of advertising a setting that has no effect.jaxrs-spec-jsonband pins the legacy Quarkus JAX-RS sample to the Maven Wrapper, since Maven 3.10 no longer ships Maven Resolver 1.x required byquarkus-maven-plugin1.x.Written for commit 6001324. Summary will update on new commits.