Skip to content

[Java][rest-assured] Remove stray Jackson 2 files from rest-assured-jackson3 sample - #25129

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
ondrej-simon:b/rest-assured-jackson3-stray-files
Oct 5, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
ondrej-simon:b/rest-assured-jackson3-stray-files

Conversation

@ondrej-simon

@ondrej-simon ondrej-simon commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

The Build Java Client JDK17 (samples/client/petstore/java/rest-assured-jackson3) job of the "Samples Java Client JDK17" workflow has been failing on master since #25112 (e.g. this run), and therefore on every PR that triggers this workflow:

RFC3339JavaTimeModule.java:[19,45] package com.fasterxml.jackson.databind.module does not exist
RFC3339InstantDeserializer.java:[26,34] package com.fasterxml.jackson.core does not exist
...

#25112 accidentally committed RFC3339InstantDeserializer.java and RFC3339JavaTimeModule.java into the rest-assured-jackson3 sample. These files are not generated for this config (they are not listed in .openapi-generator/FILES and nothing references them) and they import Jackson 2 packages, which are not on the classpath of the Jackson 3 sample.

This PR removes the two stray files. No generator or template changes.

Verified:

  • ./bin/generate-samples.sh bin/configs/java-rest-assured-jackson3.yaml does not recreate the files and produces no other changes.
  • mvn clean package of the sample (same command as CI) succeeds on JDK 17.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @wing328 (author of #25112), Java technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg @KannaKim


Summary by cubic

Removes two stray Jackson 2 files from the rest-assured-jackson3 sample that were accidentally committed and broke compilation in the "Samples Java Client JDK17" workflow. The files are not part of the generated output for this config and imported Jackson 2 packages that aren't on the classpath. No generator or template changes.

Written for commit f5b0567. Summary will update on new commits.

Review in cubic

RFC3339InstantDeserializer.java and RFC3339JavaTimeModule.java were
accidentally committed in OpenAPITools#25112. They are not produced by the generator
for this config (not listed in .openapi-generator/FILES) and use Jackson 2
packages, which breaks compilation of the Jackson 3 sample in the
"Samples Java Client JDK17" workflow.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@wing328
wing328 merged commit 2ca276c into OpenAPITools:master Oct 5, 2026
113 checks passed
rar91279 pushed a commit to rar91279/openapi-generator that referenced this pull request Oct 5, 2026
…PITools#25129)

RFC3339InstantDeserializer.java and RFC3339JavaTimeModule.java were
accidentally committed in OpenAPITools#25112. They are not produced by the generator
for this config (not listed in .openapi-generator/FILES) and use Jackson 2
packages, which breaks compilation of the Jackson 3 sample in the
"Samples Java Client JDK17" workflow.

(cherry picked from commit 2ca276c)
@ondrej-simon
ondrej-simon deleted the b/rest-assured-jackson3-stray-files branch October 6, 2026 04:04
@wing328 wing328 added this to the 7.26.0 milestone Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants