Repository navigation
[Java][rest-assured] Remove stray Jackson 2 files from rest-assured-jackson3 sample - #25129
Merged
wing328 merged 1 commit intoOct 5, 2026
Conversation
RFC3339InstantDeserializer.java and RFC3339JavaTimeModule.java were accidentally committed in OpenAPITools#25112. They are not produced by the generator for this config (not listed in .openapi-generator/FILES) and use Jackson 2 packages, which breaks compilation of the Jackson 3 sample in the "Samples Java Client JDK17" workflow.
rar91279
pushed a commit
to rar91279/openapi-generator
that referenced
this pull request
Oct 5, 2026
…PITools#25129) RFC3339InstantDeserializer.java and RFC3339JavaTimeModule.java were accidentally committed in OpenAPITools#25112. They are not produced by the generator for this config (not listed in .openapi-generator/FILES) and use Jackson 2 packages, which breaks compilation of the Jackson 3 sample in the "Samples Java Client JDK17" workflow. (cherry picked from commit 2ca276c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build Java Client JDK17 (samples/client/petstore/java/rest-assured-jackson3)job of the "Samples Java Client JDK17" workflow has been failing on master since #25112 (e.g. this run), and therefore on every PR that triggers this workflow:#25112 accidentally committed
RFC3339InstantDeserializer.javaandRFC3339JavaTimeModule.javainto therest-assured-jackson3sample. These files are not generated for this config (they are not listed in.openapi-generator/FILESand nothing references them) and they import Jackson 2 packages, which are not on the classpath of the Jackson 3 sample.This PR removes the two stray files. No generator or template changes.
Verified:
./bin/generate-samples.sh bin/configs/java-rest-assured-jackson3.yamldoes not recreate the files and produces no other changes.mvn clean packageof the sample (same command as CI) succeeds on JDK 17.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
cc @wing328 (author of #25112), Java technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg @KannaKim
Summary by cubic
Removes two stray Jackson 2 files from the
rest-assured-jackson3sample that were accidentally committed and broke compilation in the "Samples Java Client JDK17" workflow. The files are not part of the generated output for this config and imported Jackson 2 packages that aren't on the classpath. No generator or template changes.Written for commit f5b0567. Summary will update on new commits.