[BUG][Java][Spring] Mark HTTP interface configurators as @Generated - #25126
Open
axelray-dev wants to merge 4 commits into
Open
axelray-dev wants to merge 4 commits into
axelray-dev wants to merge 4 commits into
Conversation
Author
|
The samples job was failing on the generated @generated annotation in the nine Spring HTTP-interface Petstore configurations. I regenerated those outputs with bin/generate-samples.sh; the focused SpringCodegenTest passes (1/1), and git diff --check is clean. |
axelray-dev
marked this pull request as ready for review
October 5, 2026 23:02
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/others/go/oneof-not-enum/docs/EnumNullUnion.md">
<violation number="1" location="samples/client/others/go/oneof-not-enum/docs/EnumNullUnion.md:7">
P2: `EnumNullUnion` is a oneOf wrapper, not a model with a `Kind` property; the generated type contains only `NullableEnum` and `NullableExcludedEnum`. The added property and `SetKindNil`/`UnsetKind` entries document APIs that do not exist on this type; document the union alternatives instead.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| Name | Type | Description | Notes | ||
| ------------ | ------------- | ------------- | ------------- | ||
| **Kind** | Pointer to **string** | | [optional] | ||
| **Kind** | Pointer to **NullableString** | | [optional] |
Contributor
There was a problem hiding this comment.
P2: EnumNullUnion is a oneOf wrapper, not a model with a Kind property; the generated type contains only NullableEnum and NullableExcludedEnum. The added property and SetKindNil/UnsetKind entries document APIs that do not exist on this type; document the union alternatives instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/client/others/go/oneof-not-enum/docs/EnumNullUnion.md, line 7:
<comment>`EnumNullUnion` is a oneOf wrapper, not a model with a `Kind` property; the generated type contains only `NullableEnum` and `NullableExcludedEnum`. The added property and `SetKindNil`/`UnsetKind` entries document APIs that do not exist on this type; document the union alternatives instead.</comment>
<file context>
@@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
-**Kind** | Pointer to **string** | | [optional]
+**Kind** | Pointer to **NullableString** | | [optional]
## Methods
</file context>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
@Generatedannotation toHttpInterfacesAbstractConfiguratorfor both Spring HTTP interface configurator variants.PR checklist
Fixes #25121
Summary by cubic
Marks Spring HTTP interface configurators as
@Generatedso generated configurator classes are no longer flagged as hand-written, fixing #25121.@Generatedto both the default andHttpServiceProxyFactoryconfigurator templates.Written for commit eb895c2. Summary will update on new commits.