Skip to content

Update kotlin workflow to test new samples - #24749

Merged
wing328 merged 2 commits into
masterfrom
kotlin-followup
Aug 21, 2026
Merged

wing328 merged 2 commits into
masterfrom
kotlin-followup

Conversation

@wing328

@wing328 wing328 commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

a follow up pr to #24725

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Expands Kotlin samples CI to include two Petstore allOf special-discriminator variants and aligns their docs with current generator output. This increases coverage for kotlinx-serialization and multiplatform without changing behavior.

  • Adds samples/client/petstore/kotlin-allOf-special-discriminator-kotlinx-serialization and samples/client/petstore/kotlin-multiplatform-allOf-special-discriminator to the matrix in .github/workflows/samples-kotlin-client.yaml.
  • Updates docs/BirdApi.md in both samples to fix parameter table order; expect a minor CI time increase; no generator or runtime behavior changes.

Written for commit fdfbd38. Summary will update on new commits.

Review in cubic

@wing328
wing328 marked this pull request as ready for review August 21, 2026 03:53
@wing328 wing328 added this to the 7.25.0 milestone Aug 21, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wing328
wing328 merged commit 81c42b2 into master Aug 21, 2026
73 checks passed
@wing328
wing328 deleted the kotlin-followup branch August 21, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant