test(e2e): bound infra poll click actions below the poll cadence (#6787) - #6788
Open
SamuelHassine wants to merge 1 commit into
Open
test(e2e): bound infra poll click actions below the poll cadence (#6787)#6788SamuelHassine wants to merge 1 commit into
SamuelHassine wants to merge 1 commit into
Conversation
Inside the toPass() poll loops of the agent infra specs, the Endpoints-tab and endpoint-row clicks relied on the global 60s Playwright actionTimeout. If the row was not yet present in a given iteration, a single click could block for up to 60s, defeating the intended 10s polling cadence and risking the very job- level timeouts the redesign migration set out to remove. Give both clicks an explicit 5s timeout so every poll iteration stays well under the 10s cadence. Addresses the review feedback on #6786.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the Playwright E2E “agent infra” polling loops so individual click actions can’t block on the global 60s actionTimeout, preserving the intended polling cadence and reducing risk of job-level timeouts.
Changes:
- Add an explicit
timeout: 5_000to the Endpoints tab click insidetoPass()polling loops. - Add an explicit
timeout: 5_000to the endpoint-row click insidetoPass()polling loops (with clarifying inline comment).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openaev-front/tests_e2e/tests/infra/agent-implant.spec.ts | Bounds the Endpoints-tab and endpoint-row clicks to 5s within the toPass() poll loop to avoid 60s action stalls. |
| openaev-front/tests_e2e/tests/infra/agent-implant-multitenant.spec.ts | Applies the same bounded-click behavior to the multi-tenant infra poll loop for consistent cadence and reduced timeout risk. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (2.92%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6788 +/- ##
============================================
- Coverage 44.32% 44.29% -0.03%
+ Complexity 8063 8062 -1
============================================
Files 2425 2425
Lines 68682 68682
Branches 9509 9510 +1
============================================
- Hits 30440 30422 -18
- Misses 36220 36260 +40
+ Partials 2022 2000 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #6787
Summary
Follow-up nit from the review of #6786. Inside the
toPass()poll loops of the agent infra specs, the Endpoints-tab and endpoint-row clicks relied on the global 60s PlaywrightactionTimeout. If the row was not yet present in a given iteration, a single click could block for up to 60s, defeating the intended 10s poll cadence and risking the very job-level timeouts the migration set out to remove.Both clicks now take an explicit 5s timeout, keeping every poll iteration well under the 10s cadence.
Test plan
E2E Infra (x64)andE2E Infra (arm64)stay green and bounded.