Skip to content

Analysis + ADR-010 + Phases 1 & 2: hybrid JMX / OpenTelemetry driver throttling metrics - #531

Draft
rrobetti with Copilot wants to merge 7 commits into
mainfrom
copilot/analyze-throttling-metrics
Draft

rrobetti with Copilot wants to merge 7 commits into
mainfrom
copilot/analyze-throttling-metrics

Address review nit: use assertTrue instead of assertEquals(true, ...)

b74c0fd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 26, 2026 in 33s

Annotations

Check failure on line 106 in ojp-jdbc-driver-otel-metrics/src/main/java/org/openjproxy/jdbc/metrics/otel/OpenTelemetryClientThrottleMetrics.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "requests" 6 times.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ5Y2OU8dgK5_2HTyxT9&open=AZ5Y2OU8dgK5_2HTyxT9&pullRequest=531

Check warning on line 7 in ojp-jdbc-driver/src/main/java/org/openjproxy/jdbc/metrics/NoOpClientThrottleMetrics.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A Singleton implementation was detected. Make sure the use of the Singleton pattern is required and the implementation is the right one for the context.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ5Ut3VJ6Ms3vxq6xhm2&open=AZ5Ut3VJ6Ms3vxq6xhm2&pullRequest=531

Check warning on line 69 in ojp-jdbc-driver/src/main/java/org/openjproxy/jdbc/metrics/ClientThrottleMetricsFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ5Y2ORNdgK5_2HTyxT8&open=AZ5Y2ORNdgK5_2HTyxT8&pullRequest=531