Make role::mail::smtprelay inherit ::role::mail - #95
Merged
Conversation
deepak7340
force-pushed
the
add-inherits-role-mail-smtprelay
branch
2 times, most recently
from
August 27, 2026 11:49
cda13a3 to
1b93324
Compare
Bring role::mail::smtprelay in line with every other role subclass, which
inherit their category class (e.g. role::db::redis inherits ::role::db).
Inheriting ::role::mail pulls in the base profile chain (::role -> ::profile
-> ::common -> common::system) and evaluates it before the role body.
common::system declared common::system::mail two ways: via the
common::system::classes list and via a direct contain. role::mail::smtprelay
then declares the same class resource-style with computed params, producing:
Duplicate declaration: Class[Common::System::Mail] is already declared
Fix: drop common::system::mail from common::system::classes (it is now only
contained), and gate that contain on grep('role::mail::') instead of
grep('::mailcow'). The role::mail::* subroles own mail themselves - postfix
and smtprelay declare common::system::mail with their own params, mailcow
uses profile::mail::mailcow - so the base system must not also declare it.
deepak7340
force-pushed
the
add-inherits-role-mail-smtprelay
branch
from
August 27, 2026 12:56
1b93324 to
64f53d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.