LoadZIP Jacobians for new formulations and tests#364
Merged
abirchfield merged 16 commits intoabirchfield/zip_loadfrom Apr 8, 2026
Merged
LoadZIP Jacobians for new formulations and tests#364abirchfield merged 16 commits intoabirchfield/zip_loadfrom
abirchfield merged 16 commits intoabirchfield/zip_loadfrom
Conversation
Collaborator
pelesh
approved these changes
Apr 7, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
I believe residual tests were failing because of incorrect answer key. I updated test answers with correct numbers and pushed to this branch.
I also tweaked model parameters so that unit test answers are integer numbers for easier comparisons.
@abirchfield, please check and merge into your branch.
abirchfield
pushed a commit
that referenced
this pull request
Apr 8, 2026
* Alternate Jacobian terms for ZIPLoad. * Jacobian test for LoadZIP. * Fix phasor_load_zip test call. * Minor formatting. * LoadDataZIP --> LoadZIPData in CMakeLists. * Comment out LoadZIP df/dy for now. * Apply pre-commmit fixes * Guard LoadZIPTests.jacobian test with ENABLE_ENZYME. * Expect failure for LoadZIPTests. * LoadZIP initialization. * Fix typo. * Simplify ifrac expression in LoadZIP. * Activate df/dy term in LoadZIP with a hack for null df/dy'. * Apply pre-commmit fixes * Set correct answer key for LoadZIP test * Apply pre-commmit fixes --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: pelesh <[email protected]> Co-authored-by: pelesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the Jacobian terms computed for LoadZIP and adds Jacobian tests.
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
The residual test fails after activating the@abirchfield Please check.LoadZIPTests. Either the model implementation or the answer keys are incorrect.The$\frac{\partial f}{\partial y}$ is failing to build. This is because the internal variables are all algebraic, so $\frac{\partial f}{\partial y_p}$ is null. I need to implement a workaround for this. Implemented a workaround that I don't particularly like. We can discuss more offline.