add optional aspect ratio keeping for replacement image#75
Open
chillinger wants to merge 3 commits intoORB-HD:masterfrom
Open
add optional aspect ratio keeping for replacement image#75chillinger wants to merge 3 commits intoORB-HD:masterfrom
chillinger wants to merge 3 commits intoORB-HD:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the original version, the replacement image (given by --replaceimg) would always be rescaled to the face detection box.
This allows to keep the aspect ratio of the supplied replacement. In this case, the replacement will overflow the originally detected face box, as the shorter side is matched, the longer side overflows.
In examples/ there are two new example images showcasing this behaviour.
While updating the README I realized, that there are multiple new switches in the application which are not yet documented in the README - I updated everything together.
For full transparency: I used claude code for some of the edits, but I'm experienced with OpenCV and checked all edits manually and fully understand their working.