fix gdir size with new params cross-ref - #1979
Merged
Merged
Conversation
Member
Author
|
I note that #1908 would have probably prevented this from happening - probably worth prioritising this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't pickle the cfg.PARAMS snapshot with every flowline
Flowline.settings carried a shallow copy of cfg.PARAMS, which holds
intersects_gdf - a region-wide table. It was serialized into
model_flowlines.pkl once per glacier, up to five times per glacier
across levels 3 to 5, making L5 directories of dense regions such as
RGI60-19 up to 11x bigger than in v1.6.3.
Flowline, FlowlineModel and ModelSettings now drop that snapshot before
pickling and rebuild it from cfg.PARAMS on unpickling, as
GlacierDirectory already does since #1967