Skip to content

[20.0] [MIG] sale_timesheet_line_exclude: Migration to 20.0 - #976

Open
Borruso wants to merge 30 commits into
OCA:20.0from
Borruso:20.0-mig-sale_timesheet_line_exclude
Open

Borruso wants to merge 30 commits into
OCA:20.0from
Borruso:20.0-mig-sale_timesheet_line_exclude

Conversation

@Borruso

@Borruso Borruso commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

@OCA-git-bot OCA-git-bot added mod:sale_timesheet_line_exclude Module sale_timesheet_line_exclude series:20.0 labels Oct 19, 2026

@bm1-phillip bm1-phillip left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review on Odoo 20.0 Community (nightly 20261110), l10n_de (SKR03). We use this module in production on 19.0 for goodwill hours.

The 7 tests pass, no warnings from the module in the log.

Checked with the ORM as two employees: with the group "Exclude timesheets from sale order" a user can set the flag on their own timesheet; the sales order line is removed from the entry and the delivered quantity drops, and both come back when the flag is removed. Without the group the field is not in fields_get() and writing it raises an access error.

LGTM.

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

Include this :- db9e857

alexey-pelykh and others added 24 commits November 20, 2026 09:59
* [FIX] sale_timesheet_line_exclude: fix manifest
* [FIX] sale_timesheet_task_exclude: fix manifest
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-15.0/timesheet-15.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-sale_timesheet_line_exclude/fr/
We don't copy the field by default, because it breaks the
OE timesheet grid for users in the security group that hides
the field.

Functionally, it also makes sens to not copy this field,
because it is better to consider the new line not excluded
by default.
…clude flag

While the test does not reveal this, without this change, clicking on the
checkbox in the timesheet list view
does not reset the so line.
Currently translated at 100.0% (7 of 7 strings)

Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_line_exclude/it/
@Borruso
Borruso force-pushed the 20.0-mig-sale_timesheet_line_exclude branch from 2651738 to d461602 Compare November 20, 2026 09:01
@oca-cla-bot

oca-cla-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.