Skip to content

[17.0][MIG] hr_utilization_report: Migration to 17.0 - #747

Open
BhaveshHeliconia wants to merge 47 commits into
OCA:17.0from
HeliconiaIO:17.0-mig-hr_utilization_report
Open

BhaveshHeliconia wants to merge 47 commits into
OCA:17.0from
HeliconiaIO:17.0-mig-hr_utilization_report

Conversation

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

No description provided.

@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from 72b076a to d739f09 Compare March 4, 2025 07:13
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Mar 6, 2025
13 of 18 tasks
@github-actions

github-actions Bot commented Jul 6, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from d739f09 to b2b2fb4 Compare July 9, 2025 12:23
@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

Hey @OCA/project-service-maintainers would be great if someone could have a look at this module.

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 13, 2025
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from b2b2fb4 to 7e3638e Compare October 27, 2025 08:45

@alexey-pelykh alexey-pelykh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up the 17.0 migration! As the original author — the migration looks solid. Reviewed the 18.0 port as well (#748) and this follows the same pattern.

LGTM.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 5, 2026
alexey-pelykh and others added 19 commits July 6, 2026 16:13
Currently translated at 100.0% (93 of 93 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/de/
Currently translated at 61.3% (57 of 93 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/es/
Currently translated at 100.0% (93 of 93 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/es/
mymage and others added 20 commits July 6, 2026 16:13
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (100 of 100 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from 7e3638e to 1500051 Compare July 6, 2026 10:43
@OCA-git-bot OCA-git-bot added series:17.0 mod:hr_utilization_report Module hr_utilization_report labels Jul 6, 2026
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 12, 2026
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from 1500051 to b3849b0 Compare October 9, 2026 11:14

@innovara innovara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues in report/hr_utilization_report.py, both from the string formatting being rewritten:

  1. Line 307 uses named placeholders with a tuple, _('"%(report_name)s" report with "%(report_type)s" type not found') % (report_name, report_type), which raises TypeError: format requires a mapping, not tuple instead of the UserError. Passing them to _() as keyword arguments would fix it: _('"%(report_name)s" report with "%(report_type)s" type not found', report_name=report_name, report_type=report_type).
  2. Lines 855, 930 and 936 use f-strings inside _(), so the text is built before translation and can't be translated. _("Amount, %s", uom_hour.name) and similar would keep them translatable.

Assisted-by: LLM

@BhaveshHeliconia
BhaveshHeliconia force-pushed the 17.0-mig-hr_utilization_report branch from b3849b0 to db92a98 Compare November 19, 2026 12:16
@oca-cla-bot

oca-cla-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@innovara Fixed both the named placeholders in _() and the f-strings to keep strings properly translatable and aligned with the .pot file. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_utilization_report Module hr_utilization_report series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.