Repository navigation
[17.0][MIG] hr_utilization_report: Migration to 17.0 - #747
BhaveshHeliconia wants to merge 47 commits into
Conversation
72b076a to
d739f09
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
d739f09 to
b2b2fb4
Compare
|
Hey @OCA/project-service-maintainers would be great if someone could have a look at this module. |
b2b2fb4 to
7e3638e
Compare
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for picking up the 17.0 migration! As the original author — the migration looks solid. Reviewed the 18.0 port as well (#748) and this follows the same pattern.
LGTM.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Currently translated at 100.0% (93 of 93 strings) Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/de/
Currently translated at 61.3% (57 of 93 strings) Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/es/
Currently translated at 100.0% (93 of 93 strings) Translation: timesheet-12.0/timesheet-12.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_utilization_report/es/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Currently translated at 100.0% (95 of 95 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/
Currently translated at 100.0% (100 of 100 strings) Translation: timesheet-14.0/timesheet-14.0-hr_utilization_report Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_utilization_report/it/
7e3638e to
1500051
Compare
1500051 to
b3849b0
Compare
innovara
left a comment
There was a problem hiding this comment.
Two issues in report/hr_utilization_report.py, both from the string formatting being rewritten:
- Line 307 uses named placeholders with a tuple,
_('"%(report_name)s" report with "%(report_type)s" type not found') % (report_name, report_type), which raisesTypeError: format requires a mapping, not tupleinstead of theUserError. Passing them to_()as keyword arguments would fix it:_('"%(report_name)s" report with "%(report_type)s" type not found', report_name=report_name, report_type=report_type). - Lines 855, 930 and 936 use f-strings inside
_(), so the text is built before translation and can't be translated._("Amount, %s", uom_hour.name)and similar would keep them translatable.
Assisted-by: LLM
b3849b0 to
db92a98
Compare
|
The following commit authors need to sign the Contributor License Agreement:
|
|
@innovara Fixed both the named placeholders in _() and the f-strings to keep strings properly translatable and aligned with the .pot file. Thanks for the review! |
No description provided.