Skip to content

[16.0][IMP] stock_average_daily_sale: enable to choose the strategies used in config - #547

Open
nicolas-delbovier-acsone wants to merge 1 commit into
OCA:16.0from
acsone:16.0-imp-stock_average_daily_sale-configurable-strategies
Open

nicolas-delbovier-acsone wants to merge 1 commit into
OCA:16.0from
acsone:16.0-imp-stock_average_daily_sale-configurable-strategies

Conversation

@nicolas-delbovier-acsone

@nicolas-delbovier-acsone nicolas-delbovier-acsone commented Oct 1, 2026 •

Copy link
Copy Markdown

Based on: #545 (to be merged first)

image

cc @jbaudoux

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @jbaudoux,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:16.0 mod:stock_average_daily_sale Module stock_average_daily_sale labels Oct 1, 2026
Comment thread stock_average_daily_sale/models/stock_average_daily_sale_config.py Outdated
@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-stock_average_daily_sale-configurable-strategies branch from e26c23e to 06f80ab Compare October 21, 2026 07:05

@jbaudoux jbaudoux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you clean the terminology, can you drop all occurrence of sale and replace by consumption. This module doesn't measure sales

<field name="exclude_weekends" />
</group>
</group>
<group name="strategies" string="Strategies">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<group name="strategies" string="Strategies">
<group name="strategies" string="Reorder point strategies">

string="Average Daily Usage"
>
<div colspan="2" class="text-muted fst-italic mb-2">
Target quantity = (Number of Days × Average Daily Quantity) + Safety Buffer.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Target quantity = (Number of Days × Average Daily Quantity) + Safety Buffer.
Min = (Average Daily Quantity x Number of Days) + Safety

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add also doc for
Safety = Daily Standard Deviation * Safety Factor * sqrt(nbr days in the analyzed period)

</group>
<group name="average_sales_strategy" string="Average Sales">
<div colspan="2" class="text-muted fst-italic mb-2">
Target quantity = Number of Sales to Cover × Average Quantity per Sale.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Target quantity = Number of Sales to Cover × Average Quantity per Sale.
Min = Average Consumption Quantity x Factor

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you use the term "Consumption" here? This does not make sense to me? IMO "Number of sales" was clearer since we are indeed computing the number of SO's... What do you have in mind with this terminology?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nothing about sales: Collect moves from the config location to outside that location

</group>
<group name="max_sales_strategy" string="Max Sales">
<div colspan="2" class="text-muted fst-italic mb-2">
Target quantity = Max Quantity in one Sale.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a factor here as well

Suggested change
Target quantity = Max Quantity in one Sale.
Min = Max Consumption Quantity x Factor

@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-stock_average_daily_sale-configurable-strategies branch from 06f80ab to cbd7089 Compare October 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:stock_average_daily_sale Module stock_average_daily_sale series:16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants