Skip to content

[20.0][MIG] hr_employee_relative: Migration to 20.0 - #1627

Open
mileo wants to merge 39 commits into
OCA:20.0from
kmee:20.0-mig-hr_employee_relative
Open

mileo wants to merge 39 commits into
OCA:20.0from
kmee:20.0-mig-hr_employee_relative

Conversation

@mileo

@mileo mileo commented Sep 30, 2026

Copy link
Copy Markdown
Member

Standard migration from 19.0 (history kept with git format-patch/git am), pre-commit auto fixes in a separate commit.

Changes for 20.0:

  • ir.model.access.csv replaced by ir.access.csv;
  • age computed with fields.Date.today() (ruff DTZ005);
  • USAGE with the 20.0 path and a screenshot.

Installs and passes its tests on Odoo 20.0 with no warnings in the log.

alexey-pelykh and others added 30 commits September 29, 2026 16:09
Currently translated at 100.0% (32 of 32 strings)

Translation: hr-14.0/hr-14.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/pt_BR/
Currently translated at 93.7% (30 of 32 strings)

Translation: hr-14.0/hr-14.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/
Currently translated at 15.6% (5 of 32 strings)

Translation: hr-16.0/hr-16.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/it/
Currently translated at 100.0% (32 of 32 strings)

Translation: hr-16.0/hr-16.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/es/
Currently translated at 100.0% (32 of 32 strings)

Translation: hr-16.0/hr-16.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/fr/
Currently translated at 100.0% (32 of 32 strings)

Translation: hr-16.0/hr-16.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-17.0/hr-17.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_employee_relative/
Currently translated at 100.0% (33 of 33 strings)

Translation: hr-17.0/hr-17.0-hr_employee_relative
Translate-URL: https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_employee_relative/it/
@OCA-git-bot OCA-git-bot added mod:hr_employee_relative Module hr_employee_relative series:20.0 labels Sep 30, 2026
@mileo
mileo marked this pull request as ready for review September 30, 2026 10:35
@mav-adhoc

Copy link
Copy Markdown

Tested on Odoo 20.0: installs clean on a fresh database and the 4 tests pass. The ir.access.csv conversion matches the core 20.0 format and keeps the same permissions as 19.0.

Two minor notes:

  • The [MIG] commit also adds readme/USAGE.md and a new screenshot that were not in 19.0. Those are improvements and usually go in a separate commit.
  • Pre-existing, not from this migration: base.group_user gets read access on hr.employee.relative with no domain, so any internal user can read the relatives of every employee over RPC (the form page is restricted to hr.group_hr_user, so the UI does not show it). Worth a follow-up issue.

@mav-adhoc mav-adhoc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against 19.0 and the 20.0 core. Installs clean on a fresh 20.0 database and the 4 tests pass. The 19.0 history is complete in the branch, the ir.access.csv conversion keeps the same groups and operations, and the three core fields the module hides (spouse_complete_name, spouse_birthdate, children) are still in the same form view in 20.0. Nothing blocking.

Two non-blocking notes, both already mentioned above: the [MIG] commit also adds readme/USAGE.md and a screenshot that did not exist in 19.0, and it changes _compute_age from datetime.now() to fields.Date.today() — asked for by the linter, not by the version jump; the resulting years/months/days do not change.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.