Repository navigation
[18.0][ADD] hr_user_role_activity: assign role expiration reminders to the manager - #1626
Open
MohamedOsman7 wants to merge 1 commit into
Open
MohamedOsman7 wants to merge 1 commit into
MohamedOsman7 wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:hr_user_role_activity
MohamedOsman7
marked this pull request as ready for review
September 29, 2026 09:26
CRogos
force-pushed
the
18.0-add-hr_user_role_activity
branch
from
October 5, 2026 09:47
99dec28 to
a0d10ca
Compare
|
@sebalix could you also have a look at this PR? |
|
@bofiltd could you do a quick review. This is related to the PR OCA/server-backend#397, you've previously reviewed. (the hr dependency was removed from the other PR and this glue module was added) |
|
@sebalix could you do a quick review of this module? It is a companion which you've merged, and very simple. OCA/server-backend#397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue module between base_user_role_activity and hr. Overrides res.users._get_role_manager() to assign the reminder activity to the manager of the related employee, falling back to the user itself.
Depends on base_user_role_activity OCA/server-backend#397