[18.0][MIG] cooperator

[marcos-mendez]

Migration of cooperator to 18.0, with the full 16.0 commit history preserved (292 commits, original authorship kept) and a single migration commit on top.

Restructured from the original multi-module submission following the reviewers' convention of one module per PR. The dependent modules are submitted separately: cooperator_portal, cooperator_website and l10n_br_cooperator #183 (portal), #184 (website) and #185 (l10n_br_cooperator).

Migration highlights

• attrs/states converted to expression syntax; Python field-level states moved to view-level readonly expressions
• account.chart.template hook ported to the AbstractModel API — cooperator accounting initialization works on new companies
• account.account created through with_company(); res.company ported to chart_template / _existing_accounting()
• mail templates ported to report_template_ids, attachment filenames preserved through print_report_name
• report layout and invoice report re-anchored on the 18.0 templates
• account.invoice.report._select() composes SQL objects (string concatenation raised TypeError)

Bugs found and fixed during the migration

1. block_subscription_request wrote state "block" while the selection defines "blocked" — the Block button raised ValueError when clicked.
2. The confirmation mail email_to evaluated ", " + False for company requests without a company email, aborting the request creation (guarded; the data file is noupdate).
3. The partner-create-subscription wizard created the representative with cooperator=True, which raises ValidationError since the cooperative-membership refactor.
4. cooperative.membership.get_cooperator_from_crn() searched company_register_number on the membership model itself; the field lives on res.partner and the method crashed on every call.

subscription.request.create() also batches properly now (40 records: 307 → 229 queries).

Quality

• 126 tests for this module, 0 failures (upstream had 85 for the whole family)
• Coverage 96.5%
• pre-commit green with the 18.0 branch configuration
• Running in production on a database migrated from 16.0 via OpenUpgrade

[huguesdk]

thanks for your contribution.

first of all, please read this: https://github.com/OCA/.github/blob/master/AI_POLICY.md

i’m not going to read lengthy verbose ai-generated descriptions and commit messages that are probably only partly correct.

important: most modules in this repository had a different name in version 12.0 and earlier (for example, cooperator was called easy_my_coop). please see the full history in 16.0 to find out the previous names. it’s important to keep the full commit history. until now, we did that by providing multiple directories to git format-patch. but a better solution is to rename the directory in the commit history itself by using git filter-branch, as explained here (see “If the module is renamed…”).

also: if an ai agent replies to this, this pr will be closed.

[marcos-mendez]

Ok @huguesdk let me see what i can do here. Sorry for the history coopiteasy lost.

[huguesdk]

thank you for your (human) answer. ☺️ no worries about the commit history, it’s difficult to find out without knowing.

another thing to pay attention to: although the commit history is there, it seems that the migration commit is based on an quite older version of the code, as it is missing all the changes from the 16.0 branch that happened in the last 2 years: #144, #140, #166, #169, #162, #170, #171, #173 (claiming that it fixed a bug, that was actually already fixed) and #176. please base the migration on the latest version of the 16.0 branch.