Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jamesbraza
left a comment
jamesbraza
left a comment
There was a problem hiding this comment.
LGTM, few comments. Note I am unassociated with SkyRL team
| rope_scaling: Optional[Dict[str, Any]] = None | ||
| rope_theta: Optional[float] = None | ||
| log_example_interval: int = 1 | ||
| """Log an example prompt every N training steps, ``-1`` to disable""" |
There was a problem hiding this comment.
Should we document the implication of setting to 0? It seems 0 also silently disables it right now
| dump_eval_results: bool = True | ||
| rope_scaling: Optional[Dict[str, Any]] = None | ||
| rope_theta: Optional[float] = None | ||
| log_example_interval: int = 1 |
There was a problem hiding this comment.
Hugging Face has a logging_first_step: bool that let's you control if logs are emitted when global step is 0, what do you think of adding that one too?
There was a problem hiding this comment.
Logs here are already emitted when global_step is 0 since we take global_step % log_interval == 0 so you see the first logs in every scenario unless it's turned off, so I'd probs not add that new config field
2 participants
Re: Configuration flag(s) to disable log_example in training/eval loops #1497
New
log_example_intervalconfig field controls how frequently train logs the prompt, response and reward.Train:
Evaluate
eval_intervalalready controls eval frequency