Skip to content

cfv: fix build on Darwin - #564348

Merged
pbsds merged 1 commit into
NixOS:masterfrom
iedame:fix/cfv
Sep 19, 2026
Merged

pbsds merged 1 commit into
NixOS:masterfrom
iedame:fix/cfv

Conversation

@iedame

@iedame iedame commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Fix Darwin build of cfv

cfv's test suite contains tests that rely on filesystem behavior that differs on Darwin.

This change adds two Darwin-specific patches:

  1. Skip the undecodable-filename tests on Darwin, where the expected cferror status is not produced.
  2. Skip the case-insensitive filesystem tests on Darwin, as they assume a case-sensitive filesystem.

The tests remain enabled on other platforms. I also tested the package natively on macOS and verified that cfv can create and verify checksums successfully.

homebrew and MacPorts distribute this package on darwin by disabling upstream tests, I decided to only disable the non-compatible tests.

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested a review from jjtt September 17, 2026 21:32
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 17, 2026
@iedame

iedame commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (d5406bd)

Command: nixpkgs-review pr 564348
Commit: 3ed7ad73bea8fb839bebc22aa8555827a25344d7 (subsequent changes)
Merge: bd44bafa8780f2a666f0062f1fe21966cfa7f541

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/35280884544/attempts/1


x86_64-linux

✅ No rebuilds


aarch64-linux

✅ No rebuilds


x86_64-darwin

✅ No rebuilds


aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • cfv

@jjtt jjtt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll also try pushing the change upstream with:

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 18, 2026
@pbsds
pbsds added this pull request to the merge queue Sep 19, 2026
Merged via the queue into NixOS:master with commit d60a3b0 Sep 19, 2026
34 checks passed
@iedame
iedame deleted the fix/cfv branch September 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants