Escape group-by and rollup keys when rendering expressions#1245
Merged
Conversation
DataExpr.GroupBy/DropRollup/KeepRollup.toString joined grouping keys with a raw comma, so a key containing a special character (comma, colon, whitespace, or a standalone paren) did not round-trip: re-parsing the rendered expression would split or misinterpret the key. The parser unescapes keys on input, so the render side must re-escape them. Escape each key via Parser.escape on render, matching Query.In/Query.Equal and the Atlas server (DataExpr.GroupBy.exprString). Factor the shared escape-and-join into DataExpr.escapeKeys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataExpr.GroupBy/DropRollup/KeepRollup.toString joined grouping keys with a raw comma, so a key containing a special character (comma, colon, whitespace, or a standalone paren) did not round-trip: re-parsing the rendered expression would split or misinterpret the key. The parser unescapes keys on input, so the render side must re-escape them.
Escape each key via Parser.escape on render, matching Query.In/Query.Equal and the Atlas server (DataExpr.GroupBy.exprString). Factor the shared escape-and-join into DataExpr.escapeKeys.