bugfix/CSTACKEX-135: added Netapp ontap screen during zone creation#39
bugfix/CSTACKEX-135: added Netapp ontap screen during zone creation#39piyush5netapp wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds NetApp ONTAP as a supported primary storage provider in the zone creation wizard flow, wiring UI fields through to the storage pool creation API parameters.
Changes:
- Extend zone wizard primary storage step to display NetApp ONTAP-specific fields (IP, credentials, SVM) and constrain protocol choices to NFS3/ISCSI.
- Populate
createStoragePoolparameters for NetApp ONTAP during zone launch, including an ONTAP-specific URL builder. - Introduce an optional “number-format” validator hook in the shared
StaticInputsForm.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ui/src/views/infra/zone/ZoneWizardLaunchZone.vue | Adds NetApp ONTAP-specific parameter mapping and ontapURL() helper during primary storage creation. |
| ui/src/views/infra/zone/ZoneWizardAddResources.vue | Adds NetApp ONTAP UI fields and protocol options; hides capacity IOPS/URL fields for this provider. |
| ui/src/views/infra/zone/StaticInputsForm.vue | Adds optional numeric-format validation support via field.number. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (field.number) { | ||
| this.rules[field.key].push({ | ||
| validator: this.checkNumberFormat, | ||
| message: this.$t('message.error.number') | ||
| }) | ||
| } |
There was a problem hiding this comment.
The new field.number validation looks unused: a repo-wide search shows no field definitions passing number: true, so this validator and rule branch won’t run for any current forms. Either add number: true to the relevant numeric/string-numeric fields (e.g., capacity fields) or remove this to avoid carrying dead code.
| if (field.number) { | |
| this.rules[field.key].push({ | |
| validator: this.checkNumberFormat, | |
| message: this.$t('message.error.number') | |
| }) | |
| } |
|
could u please add screen shot or have a live demo for these UI changes? |

Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?