Auth check for HF repos + better errors - #1683
Conversation
| config.json | ||
| secrets.json | ||
| *.zip | ||
| training_presets/*.json |
There was a problem hiding this comment.
was this intended? this would ignore new presets I created
There was a problem hiding this comment.
Also modifies the gitignore so that we dont try to commit users presets that sit in ./training_presets (but still track presets in sub folders)
Intended, doesn’t do what you describe, tested, ignores only those directly in training_presets and has no recursive behaviour
There was a problem hiding this comment.
make it ignore just #.json then please
user configs are already saved to training_configs not _presets
training_presets could still carry a .json file directly in the folder. just not currently because I've moved all to subfolders. if a model only has 1 preset I'd probably not put it in a subfolder
| model.model_spec = self._load_default_model_spec(model_type) | ||
|
|
||
| if model_names.base_model is not None: | ||
| base_model_loader._validate_hf_repo_access(model_names.base_model) |
There was a problem hiding this comment.
I think these 3 are redudant. the model loader will eventually call one the submodule functions and reach validate_hf_repo_access
Users keep foot gunning on getting access to HF repos, including more experienced users. This attempts suppress the unnecessary parts of the error chain for hf auth. Also modifies the gitignore so that we dont try to commit users presets that sit in ./training_presets (but still track presets in sub folders)
AI assistance
AI-assisted. First time trying this, something small scope. CGPT 5.6 Sol. Read every line and tested, online, offline and 'I have access' to the model