Repository navigation
Add expect_response to klat.response messages - #198
Merged
NeonDaniel merged 1 commit intoAug 14, 2026
Merged
NeonDaniel merged 1 commit into
NeonDaniel merged 1 commit into
Conversation
The `listen` flag (from `speak` message `expect_response`) is passed into `WrappedTTS.execute` but was dropped when building `klat.response`, so remote clients (neon-hana Node WebSocket, MQ/klat clients) have no way to know a skill expects a reply and should re-open the mic. Local playback handles this via `mycroft.mic.listen` after TTS, but klat sessions never reach that path, breaking `get_response` and converse prompts for remote Nodes. Include the flag in the `klat.response` payload so clients can trigger listening after response playback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mikejgray
marked this pull request as ready for review
July 31, 2026 02:34
NeonDaniel
approved these changes
Aug 14, 2026
NeonDaniel
left a comment
NeonDaniel
left a comment
Member
There was a problem hiding this comment.
Changes here look good; added a note that neon-data-models also needs an update to support this new param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
speakmessages carryexpect_response, which reachesWrappedTTS.executeaslistenbut is dropped when buildingklat.response. Local playback signals this viamycroft.mic.listenafter TTS; klat/MQ sessions never reach that path, so remote clients (e.g. hana Node WebSocket) can't know a skill expects a reply. This breaksget_responseand converse prompts for those clients.Add
expect_responseto theklat.responsepayload so clients can trigger listening after playback.Issues
Other Notes
Extended the existing
test_executeklat assertions to cover the new key.🤖 Generated with Claude Code