120 v curve coeff bugfix#230
Open
jmaguire1 wants to merge 3 commits into
Open
Conversation
… inadvertantly swapped out the capacity/COP coefficients between the 120V shared circuit product and the 240V products. Correcting that error on dev
jmaguire1
marked this pull request as draft
June 9, 2026 22:35
jmaguire1
marked this pull request as ready for review
June 9, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by Janelle at School of Mines.
When I added 120V HPWHs in, I messed up which product uses which COP curve. The 120V shared circuit is inappropriately using the 240V COP curve and vice versa.
Here is what it was on main when we only supported 240V. Now we have the correct COP curve, matching what was done on main, for the 240V products.