Skip to content

11392 MRT Inconsistencies#11666

Open
RKStrand wants to merge 4 commits into
developfrom
11392MRTInconsistencies
Open

11392 MRT Inconsistencies#11666
RKStrand wants to merge 4 commits into
developfrom
11392MRTInconsistencies

Conversation

@RKStrand

Copy link
Copy Markdown
Contributor

Pull request overview

Description of the purpose of this PR

To promote the wide accessibility of this NFP.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

RKStrand added 2 commits June 23, 2026 20:23
This is the first posting of the NFP for review.
Revison of the NFP based on Comments from Technicalities Call on June 24. 2026
@RKStrand RKStrand self-assigned this Jun 30, 2026
@RKStrand RKStrand added the NewFeature Includes code to add a new feature to EnergyPlus label Jun 30, 2026
Comment on lines +38 to +40
### Approach 2: New Real Number Field Allowing a Combination of MRT Calculations

In this approach, the zone level MRT would be calculated using a combination of the different MRT values from all of the people statements defined for the zone. So, if say a zone had three different people statements, the user could define the zone MRT with weighting factors of 0.4 for the first people statement, 0.3 for the second people statement, and 0.2 from the third people statement. In this case, since the fractions are less than 1.0, the remainder of the average would come from the standard zone MRT calculation that is an area-emissivity weighted average of the surfaces within the zone. The new field would be limited between 0.0 and 1.0. So, if this field is 0.4, 0.3, and 0.2, respectively for the first, second, and third People statements of a zone and no other people statements have a non-zero value and since these three fractions only add up to 0.9, the remaining 0.1 fraction would come from the standard MRT calculation. When the fractions to add up to 1.0, these fractions will be used directly without modification. When the People statements have values that do not comply with the 0.0 to 1.0 range or the fractions add up to greater than 1.0, a warning message will be provided and everything will default back to the standard MRT calculation. One disadvantage to this approach is that across People input syntax, there has to be some agreement--meaning that one People statement is slightly "dependent" on another one. This would be a new "precedent", though technically one could also argue that Approach 1 also has this issue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that you need more options (and I don't necessarily love adding more EnergyPlus objects), but another possibility is to create a new ZoneMRT object with an extensible list of (PeopleObject, fraction) fields. Then you only have to check that the fractions in this one object add to less than 1.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense and would avoid issues relating to going across People statements. As we discussed in the iteration call today, this will be the approach that I take (Approach 2 with your suggestion for a new ZoneMRT object). Thanks!

@mitchute mitchute added this to the EnergyPlus 26.2 IOFreeze milestone Jul 8, 2026
RKStrand added 2 commits July 9, 2026 17:47
Updates to the NFP as a result of the Technicalities Call on July 8, 2026.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operative temperature and MRT output not consistent while requesting a different radiant temperature calculation type

4 participants