Skip to content

NFP - Interior and Exterior Material/Construction Radiant Properties - #11665

Merged
mitchute merged 5 commits into
developfrom
11393InteriorExteriorAbsorptanceFields
Jul 30, 2026
Merged

NFP - Interior and Exterior Material/Construction Radiant Properties#11665
mitchute merged 5 commits into
developfrom
11393InteriorExteriorAbsorptanceFields

Conversation

@RKStrand

Copy link
Copy Markdown
Contributor

Pull request overview

Description of the purpose of this PR

Publication of the NFP

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

RKStrand added 2 commits June 23, 2026 20:25
This is the first draft of an NFP to resolve this issue.
Changes to this NFP were made in response to the results of the technicalities call on June 24, 2026.
@RKStrand RKStrand added the NewFeature Includes code to add a new feature to EnergyPlus label Jun 30, 2026
@RKStrand RKStrand self-assigned this Jun 30, 2026
1.9.3.1.9 Field: Visible Absorptance Exterior Face
The visible absorptance field in the Material input syntax represents the fraction of incident visible wavelength radiation that is absorbed by the material. This particular field is for the exterior side or face only. Visible wavelength radiation (0.37 to 0.78 μm weighted by photopic response) is slightly different than solar radiation in that the visible band of wavelengths is much more narrow while solar radiation includes the visible spectrum as well as infrared and ultraviolet wavelengths. This parameter is used when calculating the amount of incident visible radiation absorbed by various surfaces and affects the outside surface heat balances as well as the daylighting calculations. If visible reflectance (or reflectivity) data is available, then absorptance is equal to 1.0 minus reflectance (for opaque materials). Values for this field must be between 0.0 and 1.0. The default value for this field is 0.7.

1.9.3.1.10 Field: Thermal Absorptance Interior Face

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use "Inside Face" (and "Outside Face")? At least for surfaces, it looks like there is somewhat of a precedence for that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-robertson Yes, you are correct. There is a precedent for using inside and outside face. That is what I should have used instead of interior/exterior. I will correct this in the NFP and push it up when I make other modifications based on yesterday's technicalities call. Thanks!

RKStrand added 2 commits July 9, 2026 07:59
Updates to the NFP based on discussion during the 7/8/26 technicalities call.
@mitchute

Copy link
Copy Markdown
Collaborator

Final call for comments on this NFP. This has already undergone two rounds of discussions on technicalities calls and subsequent revisions, so I think we're likely close. If anyone has final comments, please make them known ASAP.

@mitchute mitchute changed the title 11393 interior exterior absorptance fields NFP - Interior and Exterior Material/Construction Radiant Properties Jul 30, 2026

@mitchute mitchute left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is good. Thanks @RKStrand and everyone for the discussion.

@mitchute
mitchute merged commit 2f7d6d9 into develop Jul 30, 2026
8 checks passed
@mitchute
mitchute deleted the 11393InteriorExteriorAbsorptanceFields branch July 30, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move absorptance fields to Construction to better model roofs/radiant barriers/etc.

4 participants