Skip to content

Set go directive to 1.26.0 in module#2455

Closed
rajathagasthya wants to merge 1 commit into
NVIDIA:release-26.3from
rajathagasthya:release-26.3
Closed

Set go directive to 1.26.0 in module#2455
rajathagasthya wants to merge 1 commit into
NVIDIA:release-26.3from
rajathagasthya:release-26.3

Conversation

@rajathagasthya
Copy link
Copy Markdown
Contributor

Description

Minimum Go version required to build. Matches main branch.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Matches main branch.

Signed-off-by: Rajath Agasthya <[email protected]>
Comment thread go.mod
module github.com/NVIDIA/gpu-operator

go 1.25.7
go 1.26.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I prefer updating this indirectly via a dependency update. This way, we better understand our dep tree and what dependencies push our go backward compat limits

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I thought I missed this when I bumped k8s.io dependencies manually in this branch in #2445. But the on the main branch Go version was incremented because k8s.io deps were bumped to v0.36.0 (instead of v0.35.x in this branch).

I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants