Set go directive to 1.26.0 in module#2455
Closed
rajathagasthya wants to merge 1 commit into
Closed
Conversation
Matches main branch. Signed-off-by: Rajath Agasthya <[email protected]>
887d5c1 to
bfff996
Compare
tariq1890
reviewed
May 13, 2026
| module github.com/NVIDIA/gpu-operator | ||
|
|
||
| go 1.25.7 | ||
| go 1.26.0 |
Contributor
There was a problem hiding this comment.
To be honest, I prefer updating this indirectly via a dependency update. This way, we better understand our dep tree and what dependencies push our go backward compat limits
Contributor
Author
There was a problem hiding this comment.
Good point! I thought I missed this when I bumped k8s.io dependencies manually in this branch in #2445. But the on the main branch Go version was incremented because k8s.io deps were bumped to v0.36.0 (instead of v0.35.x in this branch).
I'll close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minimum Go version required to build. Matches main branch.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing