make 'numpydoc' dependency conda-only - #8556
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
I think this is working and ready for review. In the wheel tests, I do not see cuML's tests scripts don't print a summary of The only failing job here is
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe changes scope Changesnumpydoc dependency and docstring test updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes numpydoc from pip-based dependency paths while preserving it for Conda documentation and test environments; docstring validation now skips where the optional package is absent. No concrete current-head merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
482243a to
9e5ab69
Compare
|
I've re-targeted this at 26.10. I would really like to get it in if possible (will allow us to drop a patch in DLFW builds). |
|
@jameslamb This still needs a adi-packaging-codeowners review. |
|
/merge |
Closes #7710
As that issue describes,
numpydocis a fairly heavy dependency (it pulls in a lot of other packages). This proposes making the tests that depend on it conda-only, so wheel-based CI jobs don't end up installing it.Should help a bit with wheel-testing CI time here, but my main motivation is for other builds for RAPIDS like the devcontainers and DLFW builds, which are
pip-based.