Skip to content

[None][infra] Report Blossom trigger failures - #17533

Open
Mgluhovskoi wants to merge 1 commit into
NVIDIA:mainfrom
Mgluhovskoi:agent/blossom-trigger-failure-report
Open

[None][infra] Report Blossom trigger failures#17533
Mgluhovskoi wants to merge 1 commit into
NVIDIA:mainfrom
Mgluhovskoi:agent/blossom-trigger-failure-report

Conversation

@Mgluhovskoi

@Mgluhovskoi Mgluhovskoi commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Report Blossom-CI failures that occur before the downstream Jenkins pipeline starts.

The current workflow can leave the blossom-ci status pending without a PR comment when authorization, vulnerability scanning, or CI job creation fails. Add an always() finalizer on a GitHub-hosted runner that marks the commit status as failed, links to the trigger logs, and explains that the result is a trigger failure rather than a test failure.

This change does not modify the downstream L0 pipeline or automatically retry failed jobs.

Test Coverage

  • Validated .github/workflows/blossom-ci.yml with actionlint 1.7.12.
  • Exercised the embedded reporting script for Authorization, Vulnerability Scan, and Start CI Job failures with a stubbed GitHub API.
  • Ran git diff --check.

Dev Engineer Review

  • Added a Trigger-failure-report job to detect authorization, vulnerability scanning, and CI-job startup failures.
  • The job runs on a GitHub-hosted runner with always().
  • The job marks the commit status as failed and posts the failed stage and workflow-run link.
  • The change does not affect the downstream L0 pipeline or retry behavior.
  • No test files changed.

QA Engineer Review

No test changes.

Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
@Mgluhovskoi

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65444 [ run ] triggered by Bot. Commit: 78018d1 Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the failure reporter is isolated to issue-comment PR triggers and only marks authorization, scan, or trigger-stage failures.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65444 [ run ] completed with state FAILURE. Commit: 78018d1
/LLM/main/L0_MergeRequest_PR pipeline #53193 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Mgluhovskoi

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65525 [ run ] triggered by Bot. Commit: 78018d1 Link to invocation

@Mgluhovskoi
Mgluhovskoi marked this pull request as ready for review August 12, 2026 09:09
@Mgluhovskoi
Mgluhovskoi requested a review from a team as a code owner August 12, 2026 09:09
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 22d31360-6e33-479c-af61-18f51608f58d

📥 Commits

Reviewing files that changed from the base of the PR and between 6675842 and 78018d1.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml

Walkthrough

The workflow adds a Trigger-failure-report job for failed pull-request comment triggers. The job identifies the failed stage, marks the pull request head commit with a failing blossom-ci status, and posts a diagnostic comment with the workflow-run link.

Changes

Trigger failure reporting

Layer / File(s) Summary
Failure report job
.github/workflows/blossom-ci.yml
The job runs after trigger stages, identifies authorization, vulnerability-scan, or startup failures, retrieves the pull request head SHA, publishes a failing blossom-ci status, and posts a diagnostic pull-request comment.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Trigger-failure-report
  participant GitHub Actions
  participant Pull request
  Trigger-failure-report->>GitHub Actions: Detect failed trigger stage
  Trigger-failure-report->>GitHub Actions: Retrieve pull request head SHA
  Trigger-failure-report->>Pull request: Publish failing blossom-ci status
  Trigger-failure-report->>Pull request: Post diagnostic workflow-run comment
Loading

Suggested reviewers: yiqingy0, bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly describes reporting Blossom trigger failures.
Description check ✅ Passed The description explains the problem, solution, scope, and validation steps; the optional checklist is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65525 [ run ] completed with state FAILURE. Commit: 78018d1
/LLM/main/L0_MergeRequest_PR pipeline #53263 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@niukuo

niukuo commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This will lead to action failure. blossom has a strict verification for blossom-ci.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants